-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add control workspace and support check raft engine consistency #148
Conversation
Signed-off-by: yuqi1129 <yuqi4733@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI failed, you should run format and clippy at your end. The commands are listed in repo readme.
Signed-off-by: yuqi1129 <yuqi4733@gmail.com>
Signed-off-by: yuqi1129 <yuqi4733@gmail.com>
Signed-off-by: yuqi1129 <yuqi4733@gmail.com>
Signed-off-by: yuqi1129 <yuqi4733@gmail.com>
Signed-off-by: yuqi1129 <yuqi4733@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest looks good
Codecov Report
@@ Coverage Diff @@
## master #148 +/- ##
==========================================
- Coverage 97.01% 96.79% -0.22%
==========================================
Files 23 23
Lines 6065 6086 +21
==========================================
+ Hits 5884 5891 +7
- Misses 181 195 +14
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, you should add ctl to coverage ignore list:
Line 14 in 44dbcb0
- "stress" |
Got it |
Signed-off-by: yuqi1129 <yuqi4733@gmail.com>
Signed-off-by: yuqi1129 yuqi4733@gmail.com
Subtask of #144 , this PR only support check the consistency of raft-engine files