Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add control workspace and support check raft engine consistency #148

Merged
merged 8 commits into from
Nov 15, 2021

Conversation

yuqi1129
Copy link
Contributor

Signed-off-by: yuqi1129 yuqi4733@gmail.com

Subtask of #144 , this PR only support check the consistency of raft-engine files

Signed-off-by: yuqi1129 <yuqi4733@gmail.com>
Copy link
Member

@tabokie tabokie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failed, you should run format and clippy at your end. The commands are listed in repo readme.

Cargo.toml Outdated Show resolved Hide resolved
ctl/Cargo.toml Outdated Show resolved Hide resolved
ctl/src/main.rs Outdated Show resolved Hide resolved
src/engine.rs Show resolved Hide resolved
ctl/src/main.rs Outdated Show resolved Hide resolved
ctl/src/main.rs Outdated Show resolved Hide resolved
ctl/src/main.rs Outdated Show resolved Hide resolved
ctl/src/main.rs Outdated Show resolved Hide resolved
ctl/src/main.rs Outdated Show resolved Hide resolved
ctl/src/main.rs Outdated Show resolved Hide resolved
Signed-off-by: yuqi1129 <yuqi4733@gmail.com>
Signed-off-by: yuqi1129 <yuqi4733@gmail.com>
Signed-off-by: yuqi1129 <yuqi4733@gmail.com>
Signed-off-by: yuqi1129 <yuqi4733@gmail.com>
Cargo.toml Outdated Show resolved Hide resolved
Signed-off-by: yuqi1129 <yuqi4733@gmail.com>
Copy link
Member

@tabokie tabokie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest looks good

src/engine.rs Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 15, 2021

Codecov Report

Merging #148 (0b9f464) into master (44dbcb0) will decrease coverage by 0.21%.
The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #148      +/-   ##
==========================================
- Coverage   97.01%   96.79%   -0.22%     
==========================================
  Files          23       23              
  Lines        6065     6086      +21     
==========================================
+ Hits         5884     5891       +7     
- Misses        181      195      +14     
Impacted Files Coverage Δ
src/engine.rs 94.75% <14.28%> (-2.12%) ⬇️
src/file_pipe_log.rs 95.85% <0.00%> (+0.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44dbcb0...0b9f464. Read the comment docs.

Copy link
Member

@tabokie tabokie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, you should add ctl to coverage ignore list:

- "stress"

@yuqi1129
Copy link
Contributor Author

BTW, you should add ctl to coverage ignore list:

Got it

Signed-off-by: yuqi1129 <yuqi4733@gmail.com>
@tabokie tabokie merged commit 5e1f139 into tikv:master Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants