Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added hygine to macros #323

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added hygine to macros #323

wants to merge 1 commit into from

Conversation

Kixiron
Copy link

@Kixiron Kixiron commented May 16, 2020

Fixes the macro hygiene problems with the macros when not using use prometheus::*;

@breezewish
Copy link
Member

@Kixiron Thanks for the contribution! You will need to sign-off all of your commits to pass the DCO check.

@nrc This PR contains a change that is generated by later rust-protobuf. Could you help check out whether it is compatible with TiKV?

nrc
nrc approved these changes May 18, 2020
View reviewed changes
Copy link
Contributor

@nrc nrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

There are some backwards-incompatible changes but they would all cause compilation errors, so as long as Prometheus compiles, its fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrc nrc nrc approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kixiron @breezewish @nrc