macros: add register vec macros #37
Conversation
| @@ -105,6 +105,23 @@ macro_rules! register_counter { | |||
| } | |||
|
|
|||
| #[macro_export] | |||
| macro_rules! register_counter_vec { | |||
| ( $ OPTS : expr , $ LABELS_NAMES : expr ) => { | |||
There was a problem hiding this comment.
should support simple (name, help, label_names)
| } | ||
| }; | ||
|
|
||
| ( $ NAME : expr , $ HELP : expr , $ LABELS : expr , $ LABELS_NAMES : expr ) => { |
There was a problem hiding this comment.
do we must pass const labels ? I think no need.
There was a problem hiding this comment.
Just pass labels!{} for omitting const_labels.
I think it is pretty confusing if we support
( $ NAME : expr , $ HELP : expr , $ LABELS : expr , $ LABELS_NAMES : expr ) and
( $ NAME : expr , $ HELP : expr , $ LABELS_NAMES : expr ) as the same time.
It is too easy for someone to write something like register_counter_vec!("name", "help", labels!{"a" => "b",})
There was a problem hiding this comment.
why confusing? you can remove labels here, or rename LABELS to CONST_LABELS and LABELS_NAMES to VARIABLE_NAMES
|
Think we can merge #38 first and then re-update the comment for the new macros. |
|
LGTM |
Resolved #35
@siddontang @disksing