Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf context test failure #318

Closed
fredchenbj opened this issue Jul 18, 2019 · 3 comments
Closed

perf context test failure #318

fredchenbj opened this issue Jul 18, 2019 · 3 comments
Assignees
@yiwu-arbug

Comments

@fredchenbj
Copy link
Member

run cargo test on mac os, two asserts in src/perf_context.rs failed:
assert_eq!(ctx.seek_internal_seek_time(), 0); L431
assert_eq!(get_perf_level(), PerfLevel::EnableCount); L437
@yiwu-arbug yiwu-arbug changed the title cargo test failed cargo test failed on mac Jul 19, 2019
@yiwu-arbug
Copy link
Collaborator

@fredchenbj thanks for reporting. will check when we got a chance.

@yiwu-arbug
Copy link
Collaborator

@fredchenbj I'm not able to reproduce on my side. Which test fail on your side? What's your c++ compiler version? Thanks.

@fredchenbj
Copy link
Member Author

@yiwu-arbug Sorry, I didn't describe it clearly. I use cargo test -- --test-threads=1 failed at perf_context::test::test_perf_context, but cargo test works well.

@yiwu-arbug yiwu-arbug changed the title cargo test failed on mac perf context test failure Jul 22, 2019
@yiwu-arbug yiwu-arbug mentioned this issue Jul 22, 2019
Merged
@yiwu-arbug yiwu-arbug self-assigned this Jul 22, 2019
yiwu-arbug pushed a commit that referenced this issue Jul 23, 2019
Fix perf context test (#321)
09b8032 
Fixing perf context test failure with `cargo test -- --test_threads=1`. The test assume default perf level is `PerfLevel::EnableCount`, which apparently will affected by other tests.

Tested by running `cargo test -- --test_threads=1`.

Closing #318 

Signed-off-by: Yi Wu <yiwu@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yiwu-arbug yiwu-arbug

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yiwu-arbug @fredchenbj @Connor1996