-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
storage: fix reverse scan check memory locks (#11447) #11455
storage: fix reverse scan check memory locks (#11447) #11455
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
@youjiali1995 you're already a collaborator in bot's repo. |
e994814
to
e55b94a
Compare
close tikv#11440 Signed-off-by: ti-srebot <ti-srebot@pingcap.com> Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>
e55b94a
to
6201a07
Compare
/merge |
@MyonKeminta: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 6201a07
|
@ti-srebot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
cherry-pick #11447 to release-5.2
You can switch your code base to this Pull Request by using git-extras:
# In tikv repo: git pr https://github.com/tikv/tikv/pull/11455
After apply modifications, you can push your change to this PR via:
Signed-off-by: youjiali1995 zlwgx1023@gmail.com
What problem does this PR solve?
Issue Number:close #11440
Problem Summary:
Reverse scan's start_key is greater than end_key, but storage always uses [start_key, end_key) to check memory locks.
What is changed and how it works?
What's Changed:
Swap start_key and end_key if is a reverse scan.
Related changes
Check List
Tests
Side effects
Release note