Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: fix race during raft data migration #12701

Merged
merged 1 commit into from
May 31, 2022
Merged

server: fix race during raft data migration #12701

merged 1 commit into from
May 31, 2022

Conversation

tabokie
Copy link
Member

@tabokie tabokie commented May 31, 2022

Signed-off-by: tabokie xy.tao@outlook.com

What is changed and how it works?

Issue Number: Close #12698

What's Changed:

Close engine before cleaning up its data during raft engine migration.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Release note 

None

@tabokie
fix race during raft data migration
62a4238 
Signed-off-by: tabokie <xy.tao@outlook.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 31, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 5kbpers
  • Connor1996

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed labels May 31, 2022
@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.0 needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. and removed do-not-merge/needs-triage-completed labels May 31, 2022
Connor1996
Connor1996 approved these changes May 31, 2022
View reviewed changes
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 31, 2022
@tabokie tabokie requested a review from 5kbpers May 31, 2022 06:18
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 31, 2022
@tabokie
Copy link
Member Author

tabokie commented May 31, 2022

/merge

@ti-chi-bot
Copy link
Member

@tabokie: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 62a4238

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 31, 2022
@ti-chi-bot ti-chi-bot merged commit cfd0b0e into tikv:master May 31, 2022
ti-srebot pushed a commit to ti-srebot/tikv that referenced this pull request May 31, 2022
@tabokie @ti-srebot
cherry pick tikv#12701 to release-5.4
c0f2fb6 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request May 31, 2022
Closed
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #12704

ti-srebot pushed a commit to ti-srebot/tikv that referenced this pull request May 31, 2022
@tabokie @ti-srebot
cherry pick tikv#12701 to release-6.0
a800997 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request May 31, 2022
Closed
@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 in PR #12705

ti-srebot pushed a commit to ti-srebot/tikv that referenced this pull request May 31, 2022
@tabokie @ti-srebot
cherry pick tikv#12701 to release-6.1
9a8431d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request May 31, 2022
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-6.1 in PR #12706

ti-chi-bot pushed a commit that referenced this pull request Aug 22, 2022
@ti-srebot @tabokie @BusyJay
server: fix race during raft data migration (#12701) (#12706)
a116fca 
close #12698, ref #12701

Close engine before cleaning up its data during raft engine migration.

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Xinye Tao <xy.tao@outlook.com>
Co-authored-by: Jay <BusyJay@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@5kbpers 5kbpers 5kbpers approved these changes

@Connor1996 Connor1996 Connor1996 approved these changes

@BusyJay BusyJay Awaiting requested review from BusyJay

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.0 needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
5 participants
@tabokie @ti-chi-bot @ti-srebot @Connor1996 @5kbpers