-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
raftstore: make full compaction incremental, pause when load is high #15995
raftstore: make full compaction incremental, pause when load is high #15995
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/cc @tonyxuqqi @v01dstar |
/test |
/cc @Connor1996 |
389eb4f
to
a8f6bbe
Compare
a8f6bbe
to
5516025
Compare
return false; | ||
} | ||
|
||
let cpu_usage = PROCESS_STAT_CPU_USAGE.get(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we were trying to get cpu usage "over time" instead of "point in time"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after discussion with @tonyxuqqi we decided to decide on cpu usage at every 10 minute interval. so we are doing over time, but that time is a 10 minute interval. (we call it every 10 minutes, and it returns the cpu usage as defined by cpu time - cpu time last time process_stat.cpu_usage() is gotten / time - it was last called.)
Signed-off-by: Alex Feinberg <alex@strlen.net>
Signed-off-by: Alex Feinberg <alex@strlen.net>
Signed-off-by: Alex Feinberg <alex@strlen.net>
Signed-off-by: Alex Feinberg <alex@strlen.net>
Signed-off-by: Alex Feinberg <alex@strlen.net>
Signed-off-by: Alex Feinberg <alex@strlen.net>
Signed-off-by: Alex Feinberg <alex@strlen.net>
918d107
to
60b3fdf
Compare
Signed-off-by: Alex Feinberg <alex@strlen.net>
Signed-off-by: Alex Feinberg <alex@strlen.net>
Signed-off-by: Alex Feinberg <alex@strlen.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Alex Feinberg <alex@strlen.net>
/assign @tonyxuqqi |
/merge |
@tonyxuqqi: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: f6e8ebd
|
Signed-off-by: Neil Shen <overvenus@gmail.com>
ref tikv#15271 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
Issue Number: ref #15271
Testing
compact.rs
Release note