-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
raft-engine: reduce the threshold of compression and add related metrics on it. (#16906) #16967
raft-engine: reduce the threshold of compression and add related metrics on it. (#16906) #16967
Conversation
ref tikv#16907 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
/merge |
@glorv: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: afdd2a6
|
This is an automated cherry-pick of #16906
What is changed and how it works?
Issue Number: Ref #16907 ref tikv/raft-engine#358
What's Changed:
The relevant metrics will be shown just like the following shows:
And as for performance, taking
tpcc
workloads, usingv7.5.x (disable async-io and compression-threshold = 8kb as default)
as the baseline, the CPU.utilization keeps nearly same in this pr.And using smaller compression threshold with
batch-compression-threshold = 4kb, async-io
, keeps the same, and the costs of IO Bandwidth are smaller thanv8.1.0-nightly ((batch-compression-threshold = 8kb, async-io)
. (PS: smaller is better in "Disk IO Throughputs")Related changes
pingcap/docs
/pingcap/docs-cn
:Check List
Tests
Side effects
Release note