Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raft-engine: reduce the threshold of compression and add related metrics on it. (#16906) #16967

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #16906

What is changed and how it works?

Issue Number: Ref #16907 ref tikv/raft-engine#358

What's Changed:

This pr contains:
- Reduce the default compression threshold in RaftEngine to `4kb` as default if users do not manually set it.
- Add relevant metrics on the compression ratio of RaftEngine.write.

The relevant metrics will be shown just like the following shows:
image

And as for performance, taking tpcc workloads, using v7.5.x (disable async-io and compression-threshold = 8kb as default) as the baseline, the CPU.utilization keeps nearly same in this pr.
image
And using smaller compression threshold with batch-compression-threshold = 4kb, async-io, keeps the same, and the costs of IO Bandwidth are smaller than v8.1.0-nightly ((batch-compression-threshold = 8kb, async-io). (PS: smaller is better in "Disk IO Throughputs")

QPS Diff Disk IO Throughputs
image image

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

For the version of TIKV >= v8.1:
- Reduce the default compression threshold in RaftEngine to `4kb` as default if users do not manually set it.
- Add relevant metrics on the compression ratio of RaftEngine.write.

ref tikv#16907

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels May 9, 2024
Copy link
Contributor

ti-chi-bot bot commented May 9, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • LykxSassinator
  • glorv

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 9, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 9, 2024
@glorv
Copy link
Contributor

glorv commented May 9, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented May 9, 2024

@glorv: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented May 9, 2024

This pull request has been accepted and is ready to merge.

Commit hash: afdd2a6

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 9, 2024
@ti-chi-bot ti-chi-bot bot merged commit befa08e into tikv:release-8.1 May 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants