-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conf: rewrite unified pool related configurations #7946
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
sticnarf
added
type/bugfix
This PR fixes a bug.
component/configuration
Component: Configuration
needs-cherry-pick-release-4.0
Type: Need cherry pick to release 4.0
labels
May 26, 2020
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
sticnarf
force-pushed
the
fix-unified-config-display
branch
from
May 27, 2020 06:21
421540b
to
3efc1b8
Compare
youjiali1995
approved these changes
May 27, 2020
BusyJay
approved these changes
Jun 1, 2020
sticnarf
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Jun 1, 2020
/run-all-tests |
/run-cherry-picker |
sre-bot
pushed a commit
to sre-bot/tikv
that referenced
this pull request
Jun 1, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
cherry pick to release-4.0 in PR #7985 |
youjiali1995
pushed a commit
that referenced
this pull request
Jun 1, 2020
Co-authored-by: Yilin Chen <sticnarf@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/configuration
Component: Configuration
needs-cherry-pick-release-4.0
Type: Need cherry pick to release 4.0
status/can-merge
Indicates a PR has been approved by a committer.
type/bugfix
This PR fixes a bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
When TiKV starts, it prints out the configuration in the log. Currently, if
use-unified-pool
is not set,null
will be outputted. This behavior may be confusing to users and the users can fail to know the default setting TiKV uses.What is changed and how it works?
What's Changed:
Instead of silently using default settings in TiKV, this PR rewrites
use-unified-pool
with the default setting. Now TiKV prints out the real setting ofuse-unifed-pool
in the start log.Related changes
Check List
Tests
Now, even if
use-unified-pool
is not set, the real setting will be printed out like this: (previously readpool.*.use-unified.pool = null)Release note
Prints out the factual
use-unified-pool
configuration in the startup log.