-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: remove setup configuration of jemalloc profile #8813
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to jemalloc/jemalloc#585, enabling memory profiling can cause deadlock on some platform and with some version of glibc. So this pr removes it by default for best safety. Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
BusyJay
added
component/build
Component: Build, Deployment, etc.
type/bugfix
This PR fixes a bug.
needs-cherry-pick-release-4.0
Type: Need cherry pick to release 4.0
labels
Oct 12, 2020
zhouqiang-cl
approved these changes
Oct 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/release |
breezewish
approved these changes
Oct 13, 2020
ti-srebot
added
status/LGT2
Indicates that a PR has LGTM 2.
and removed
status/LGT1
Indicates that a PR has LGTM 1.
labels
Oct 13, 2020
ti-srebot
approved these changes
Oct 13, 2020
BusyJay
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Oct 13, 2020
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/tikv
that referenced
this pull request
Oct 13, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-4.0 in PR #8815 |
BusyJay
added a commit
to ti-srebot/tikv
that referenced
this pull request
Oct 13, 2020
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
Xuanwo
pushed a commit
to Xuanwo/tikv
that referenced
this pull request
Oct 28, 2020
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/build
Component: Build, Deployment, etc.
needs-cherry-pick-release-4.0
Type: Need cherry pick to release 4.0
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
type/bugfix
This PR fixes a bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
According to jemalloc/jemalloc#585, enabling memory profiling can cause
deadlock on some platform and with some version of glibc. So this pr
removes it by default for best safety.
Related changes
pingcap/docs
/pingcap/docs-cn
:pingcap/tidb-ansible
:Check List
Tests
Side effects
Release note