Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: remove setup configuration of jemalloc profile #8813

Merged
merged 2 commits into from
Oct 13, 2020

Conversation

BusyJay
Copy link
Member

@BusyJay BusyJay commented Oct 12, 2020

What problem does this PR solve?

According to jemalloc/jemalloc#585, enabling memory profiling can cause
deadlock on some platform and with some version of glibc. So this pr
removes it by default for best safety.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • PR to update pingcap/tidb-ansible:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • No release note

According to jemalloc/jemalloc#585, enabling memory profiling can cause
deadlock on some platform and with some version of glibc. So this pr
removes it by default for best safety.

Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
@BusyJay BusyJay added component/build Component: Build, Deployment, etc. type/bugfix This PR fixes a bug. needs-cherry-pick-release-4.0 Type: Need cherry pick to release 4.0 labels Oct 12, 2020
Copy link
Contributor

@zhouqiang-cl zhouqiang-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 12, 2020
@zhouqiang-cl
Copy link
Contributor

/release

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 13, 2020
@BusyJay BusyJay added the status/can-merge Indicates a PR has been approved by a committer. label Oct 13, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit a6485f3 into tikv:master Oct 13, 2020
ti-srebot pushed a commit to ti-srebot/tikv that referenced this pull request Oct 13, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #8815

BusyJay added a commit to ti-srebot/tikv that referenced this pull request Oct 13, 2020
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
Xuanwo pushed a commit to Xuanwo/tikv that referenced this pull request Oct 28, 2020
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
@BusyJay BusyJay deleted the remove-setup-jeprof branch May 13, 2021 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/build Component: Build, Deployment, etc. needs-cherry-pick-release-4.0 Type: Need cherry pick to release 4.0 status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants