Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop CF while GC is running causing background error #71

Closed
yiwu-arbug opened this issue Sep 10, 2019 · 0 comments · Fixed by #72
Closed

Drop CF while GC is running causing background error #71

yiwu-arbug opened this issue Sep 10, 2019 · 0 comments · Fixed by #72
Assignees
@yiwu-arbug

Comments

@yiwu-arbug
Copy link
Collaborator

Found by db_stress #64. On DropColumnFamilies we should wait for any running GC job before proceed.
@yiwu-arbug yiwu-arbug self-assigned this Sep 10, 2019
This was referenced Sep 10, 2019
Closed
Merged
yiwu-arbug pushed a commit that referenced this issue Sep 18, 2019
Prevent CF being dropped while GC is running (#72)
8768067 
Summary:
If `DropColumnFamilies` is called while GC is running, GC can fail because the CF is gone. The GC job will then set background error which halts Titan as a whole. To prevent it, we let `DropColumnFamilies` wait till there no running GC before proceed, and let GC job wait for pending drop CF requests before start running. Fixes #71.

Also fix `DropColumnFamilies` mark obsolete file as obsolete again, which will cause assert failure.

Test Plan:
Run titandb_stress and the above issues don't reproduce.
yiwu-arbug pushed a commit to yiwu-arbug/titan that referenced this issue Sep 24, 2019
Prevent CF being dropped while GC is running (tikv#72)
ef2f5a6 
Summary:
If `DropColumnFamilies` is called while GC is running, GC can fail because the CF is gone. The GC job will then set background error which halts Titan as a whole. To prevent it, we let `DropColumnFamilies` wait till there no running GC before proceed, and let GC job wait for pending drop CF requests before start running. Fixes tikv#71.

Also fix `DropColumnFamilies` mark obsolete file as obsolete again, which will cause assert failure.

Test Plan:
Run titandb_stress and the above issues don't reproduce.

Signed-off-by: Yi Wu <yiwu@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yiwu-arbug yiwu-arbug

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent CF being dropped while GC is running yiwu-arbug/titan
1 participant
@yiwu-arbug