Fix wrong assert delta < 0 for cocurrent compaction while flush #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
yiwu-arbug
reviewed
Jun 3, 2020
yiwu-arbug
reviewed
Jun 3, 2020
yiwu-arbug
reviewed
Jun 3, 2020
yiwu-arbug
reviewed
Jun 3, 2020
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #172 +/- ##
==========================================
- Coverage 85.90% 85.87% -0.03%
==========================================
Files 47 47
Lines 3548 3555 +7
==========================================
+ Hits 3048 3053 +5
- Misses 500 502 +2 |
|
/run-all-tests |
|
@Connor1996 merge failed. |
|
cherry pick to tikv-4.x failed |
Connor1996
added a commit
to Connor1996/titan
that referenced
this pull request
Jun 4, 2020
…#172) * fix cocurrent compaction while flush Signed-off-by: Connor1996 <zbk602423539@gmail.com>
Connor1996
added a commit
that referenced
this pull request
Jun 4, 2020
#176) * fix cocurrent compaction while flush Signed-off-by: Connor1996 <zbk602423539@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the flushed SST is added to superversion before
OnFlushCompleted()is called, so if there is a concurrent compaction,OnCompactionCompleted()maybe called beforeOnFlushCompleted()is called.In this case, the state of the blob file generated by the flush is still
kPendingLSM, while the blob file size delta is for the compaction event. So it is possible that delta is negative.Fix #171