Fix new CF missing BlobFileSizeCollector #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yi Wu <yiwu@pingcap.com>
Closed
added 3 commits
September 18, 2019 00:47
Signed-off-by: Yi Wu <yiwu@pingcap.com>
|
seems CI finds a data race case. will fix. |
added 3 commits
September 18, 2019 18:24
Signed-off-by: Yi Wu <yiwu@pingcap.com>
Signed-off-by: Yi Wu <yiwu@pingcap.com>
Codecov Report
@@ Coverage Diff @@
## master #78 +/- ##
==========================================
+ Coverage 81.71% 82.04% +0.33%
==========================================
Files 44 44
Lines 3122 3124 +2
==========================================
+ Hits 2551 2563 +12
+ Misses 571 561 -10 |
yiwu-arbug
pushed a commit
to yiwu-arbug/titan
that referenced
this pull request
Sep 24, 2019
Summary: On `CreateColumnFamilies` we should set `BlobFileSizeCollectorFactory`. Fixing it. Test Plan: added test Signed-off-by: Yi Wu <yiwu@pingcap.com>
Connor1996
pushed a commit
that referenced
this pull request
Sep 24, 2019
cherry-pick following patches ``` ff30897 2019-09-23 zbk602423539@gmail.. reset gc mark after sampling (#88) cb67cd5 2019-09-22 zbk602423539@gmail.. fix wrong property after restart (#82) c6e408c 2019-09-20 yiwu@pingcap.com Fix blob file format description (#83) fc4106d 2019-09-18 yiwu@pingcap.com Fix new CF missing BlobFileSizeCollector (#78) 10710bb 2019-09-18 zbk602423539@gmail.. Add more metrics (#79) 8768067 2019-09-17 yiwu@pingcap.com Prevent CF being dropped while GC is running (#72) 07aa065 2019-09-16 zbk602423539@gmail.. Rename version_set to blob_file_set (#69) f963b88 2019-09-16 zbk602423539@gmail.. support histogram for titan stats (#74) 144e20f 2019-09-12 wujy.cs@gmail.com gc breakdown metrics (#73) 715dbd6 2019-09-11 zbk602423539@gmail.. Update BlobFileMeta format (#68) 468ddc9 2019-09-03 yiwu@pingcap.com Add internal operation stats and dump to info log periodically (#62) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
On
CreateColumnFamilieswe should setBlobFileSizeCollectorFactory. Fixing it.Test Plan:
added test
Signed-off-by: Yi Wu yiwu@pingcap.com