Fix default XY oscilloscope size #1627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tildearrow
requested changes
Dec 6, 2023
|
In different size? Hmm... I thought it just sets the minimum sizes no matter how the window emerges on the screen. Well, what is default layout then? And how it can be used to properly fix the thing? |
|
The default layout is in src/gui/gui.cpp line 768. |
tildearrow
requested changes
Dec 7, 2023
tildearrow
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put a restriction on XY oscilloscope window size so the minimal size now is more than several pixels lol
You may tweak the numbers because I am on 4k screen and that's how in looks good for me