Fixed issue with messages missing event field in FF #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like in the latest Firefox MessageChannel is still being supplanted by this library, however because MessagePort is implemented libraries from frames without MessageChannel.js are pushing valid MessageEvents. As a result decodeEvent is receiving a legitimate MessageEvent that does not need to be faked. For these events, just pass them on as-is to avoid an ‘event is undefined’ error in the decoding.
|
Looks like tests are failing due to an old bower version. Let me know if you'd like me to update that as well. |
|
Not sure if it's a bower version issue, but it probably doesn't hurt to update it. That would be great if you could do it in this PR but in a separate commit! |
Bump the bower version to the latest 1.4.1 to fix tests.
|
Looks like there's some issue with Sauce Connect now, but I thought that was shut off for PR builds...any ideas? |
|
Closing due to staleness. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like in the latest Firefox MessageChannel is still being
supplanted by this library, however because MessagePort is implemented
frames without MessageChannel.js are pushing valid
MessageEvents. As a result decodeEvent is receiving a legitimate
MessageEvent that does not need to be faked. For these events, just
pass them on as-is to avoid an ‘event is undefined’ error in the
decoding.