Problem with path for vertx.js for browserify v7.0.2.

[mjancarik]

Browserify wants to load file from 'dist' folder, but vertx.js is in the root folder.

[stefanpenner]

please use: browserify -x vertx

[mjancarik]

I use gulp for build and I got Error.

Error: Cannot find module 'vertx' from '/web/node_modules/rsvp/dist'.

It is true because you want to require vertx.js from rsvp/dist folder, but vertx.js is in the root folder.

My gulp is:

browserify(files.src, {debug: true, insertGlobals : true})
    .bundle()
        .pipe(source(files.name))
        .pipe(gulp.dest(files.dest))

Do you have a solution?

[stefanpenner]

It is true because you want to require vertx.js from rsvp/dist folder, but vertx.js is in the root folder.

require('vertx') is for users of http://vertx.io/ your solution breaks RSVP for them. Maybe their is a way to annotate a require to be ignored by browserify?

[stefanpenner]

ah we can just do

var r = require;
r('vertx');

this will prevent browserify from detecting the require. If you can update the PR accordingly, I'll gladly merge.

[domenic]

Or use the browser field in package.json, which is cleaner.

[stefanpenner]

Or use the browser field in package.json, which is cleaner.

mind linking to a doc on that?

[domenic]

https://github.com/substack/browserify-handbook#browser-field

[fivetanley]

https://github.com/substack/browserify-handbook#browser-field

oops didn't see domenic's reply and forgot to refresh :P

[stefanpenner]

ah so

"browser": {
    "vertx": false
  }

?

[mjancarik]

Thank you for yours suggestions

[stefanpenner]

@microx i believe @domenic is suggesting it should be possible to configure browserify in rsvp.js package.json to skip this without the indirection. Do you mind updating?

[mjancarik]

Yes, it is possible and I fixed it for me, but I think that rsvp call require vertx so it will call right way. You have empty file vertx.js in root, where is comment 'to make browserify happy about trying to require('vertx')'. What do you think?

[stefanpenner]

You have empty file vertx.js in root, where is comment 'to make browserify happy about trying to require('vertx')'. What do you think?

this file was a quick hack that we shouldn't have around.

[stefanpenner]

will investigate the browserify package.json entry later