Adding Promise.fromDeferred helper to wrap jQuery Deferreds #42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RSVP is great - thoroughly clear and small enough that it can be used as a fundamental abstraction across all my JS. I'm mostly working browser-side and mostly using $.Deferred now, and was surprised that it didn't chain the way I expected. In surveying the landscape, I didn't find a good fit, mostly for the same reasons you mentioned in http://news.ycombinator.com/item?id=4662222. So thanks!
I'm not sure if this fits with your goals for the project, but I think the idea to add helper functions that can wrap other promise abstractions into RSVP.Promises would be helpful in adopting it in my projects. This pull request adds that helper function for wrapping $.Deferred and is similar to #4 which wraps functions using Node-style callback parameters.
This is a little extra cruft (and basically useless for the Node build), so maybe this works better as an extension that is part of the project but a separate output of the build.
Thanks!