Don't import historic WOF neighbourhoods #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This parses these fields as EDTF, which is brought in as an additional library dependency, and includes the start and end dates in the database rows for each entry. The visibility is tracked and updated, generating expiries to be re-rendered, which allows upstream code to only check the visibility parameter and not need to worry about the dates changing.
…e Circle isn't picking it up; trying to force an install.
| # 'edtf:deprecated' would both stop the item showing, so we take the | ||
| # earliest of each's latest possible date. | ||
| inception = edtf_inception.earliest_date() | ||
| cessation = min(edtf_cessation.latest_date(), |
|
LGTM |
zerebubuth
added a commit
that referenced
this pull request
Jan 14, 2016
…ourhoods Don't import historic WOF neighbourhoods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for WOF's
edtf:inception,edtf:cessationandedtf:deprecatedfields. This is tracked in the database and anis_visibleflag is maintained for query use. Changes to these flags result in expiries as if the data had been updated, and so the query can pick up these changes.Connects to #59.
@nvkelso could you review, please?