Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testgen.py SyntaxError with Python 3.7 #27

Closed
jiri-janousek opened this issue Jul 23, 2018 · 4 comments
Closed

testgen.py SyntaxError with Python 3.7 #27

jiri-janousek opened this issue Jul 23, 2018 · 4 comments
Labels
type: bug Something is not working as expected or the documentation is incorrect.

Comments

@jiri-janousek
Copy link
Member

Reticketed from #26 (comment)

  File "../testgen.py", line 84
    def __init__(self, name, access, parent=None, rtype=None, params=None, throws=None, override=False, abstract=False, anotations=None, async=False):
                                                                                                                                             ^
SyntaxError: invalid syntax
@jiri-janousek
Copy link
Member Author

Hello @martinkg, could you replace variable async with is_async and try again? async has become a reserved keyword in Python 3.7.

@jiri-janousek jiri-janousek added type: bug Something is not working as expected or the documentation is incorrect. help wanted Assignee needs help with this ticket. status: in progress labels Jul 23, 2018
@martinkg
Copy link

builds now fine on rawhide with replacing async by is_async

sed -i -e 's|async|is_async|g' testgen.py

@jiri-janousek
Copy link
Member Author

You cannot just blindly replace async everywhere, only variable names, never in string literals.

@jiri-janousek jiri-janousek added stalled Some work has been done but nobody is working on finishing this ticket. and removed status: in progress labels Aug 9, 2018
jiri-janousek added a commit that referenced this issue Oct 27, 2018
- `async` is a keyword
- Issue: tiliado/nuvolaplayer#469
- Issue: #27

Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
@jiri-janousek jiri-janousek added status: in progress and removed stalled Some work has been done but nobody is working on finishing this ticket. help wanted Assignee needs help with this ticket. labels Oct 27, 2018
@jiri-janousek jiri-janousek added release notes The work on the ticket is ready, but needs to be released and announced. and removed status: in progress labels Nov 9, 2018
@jiri-janousek
Copy link
Member Author

Fixed in Nuvola 4.14. Sorry that it took so long. The update to GNOME SDK 3.30, which contains Python 3.7, was tricky.

@ghost ghost removed the release notes The work on the ticket is ready, but needs to be released and announced. label Nov 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something is not working as expected or the documentation is incorrect.
Projects
None yet
Development

No branches or pull requests

2 participants