Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate track progress bar #155

Closed
jiri-janousek opened this issue Sep 5, 2015 · 6 comments
Closed

Integrate track progress bar #155

jiri-janousek opened this issue Sep 5, 2015 · 6 comments
Milestone
September 2017

Comments

@jiri-janousek
Copy link
Member

jiri-janousek commented Sep 5, 2015 •
edited
Loading

Feedback from @tcitworld:

  1. Which feature are you missing in Nuvola Player most?

Full control through Gnome Media Player indicator (can be buggy).
[...]
I remember the progress bar wasn't enabled, at least for the Deezer plugin.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
@tcitworld
Copy link

I got the chance to test it in cinnamon and the same problem happens. Moreover, album title is always marked as « unknown ».

@jiri-janousek
Copy link
Member Author

Moreover, album title is always marked as « unknown ».

That's correct because Deezer doesn't show album name in its web interface.

@tcitworld
Copy link

Oh. OK. Didn't noticed this with other desktop environments.

@jiri-janousek jiri-janousek added this to the 3.1.0 milestone Nov 13, 2015
@jiri-janousek jiri-janousek modified the milestones: March 2016, 3.1.0 Jan 15, 2016
@jiri-janousek jiri-janousek modified the milestones: 3.2.0, March 2016 May 30, 2016
@jiri-janousek jiri-janousek modified the milestones: 3.4, 3.2.0 Sep 13, 2016
@jiri-janousek jiri-janousek modified the milestones: 4.0.0, 3.4, 4.x, 4.0 Feb 6, 2017
@jiri-janousek
Copy link
Member Author

Related MPRIS API:

jiri-janousek added a commit that referenced this issue Jun 11, 2017
@jiri-janousek
Add API for track position/seek
347085e 
Issue: #155

JavaScript API:

  * MediaPlayer.setTrackPosition(position) - to update current track
    position
  * MediaPlayer.setTrack(track) - supports track.length property
  * New action PlayerAction.SEEK - to seek in a desired position in the
    track, called with the new position as parameter
  * New flag MediaPlayer.setCanSeek(state) - to enable remote seeking

Nuvola Runtime:

  * Developer sidebar updated to show track position and length
  * Test service got progress bar
  * MPRIS plugin updated

IPC API:
  * /nuvola/mediaplayer/track-position - get track position
  * /nuvola/mediaplayer/set-track-position - set track position
  * /nuvola/mediaplayer/track-position-changed - notification

Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
@jiri-janousek jiri-janousek mentioned this issue Jun 11, 2017
Closed
@jiri-janousek
Copy link
Member Author

jiri-janousek commented Jun 11, 2017 •
edited
Loading

All required APIs have been added to the master branch (Nuvola 4.4.13). Remaining tasks:

  • Write documentation for maintainers.
  • Integrate progress bar in my streaming services
  • Ask maintainers of the other services to integrate progress bar.

jiri-janousek added a commit to tiliado/nuvola-app-deezer that referenced this issue Jun 12, 2017
@jiri-janousek
Integrate progress bar
fd66209 
Issue: tiliado/nuvolaplayer#155

Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
@jiri-janousek jiri-janousek modified the milestones: 4.5, 5.x Jun 17, 2017
jiri-janousek added a commit to tiliado/nuvola-app-google-play-music that referenced this issue Jun 23, 2017
@jiri-janousek
Integrate progress bar
24a4bd9 
Issue: tiliado/nuvolaplayer#155

Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
jiri-janousek added a commit to tiliado/nuvola-app-google-play-music that referenced this issue Jun 23, 2017
@jiri-janousek
Release 5.19 - June 18th, 2017
848fd72 
  * Malfunctioning Google sign-in page has been fixed by setting the
    user agent string to WebKit. Issue: tiliado/nuvolaplayer#336
  * Don't check setting THUMB_NEVER_TOGGLES too often.
  * Metadata was updated according to the latest Nuvola SDK
    requirements.
  * Progress bar is fully integrated - it is possible to show track
    position and change it as well. Issue: tiliado/nuvolaplayer#155
  * Volume management is fully integrated - it is possible to show
    volume and change it as well. Issue: tiliado/nuvolaplayer#22

Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
jiri-janousek added a commit to tiliado/nuvola-app-deezer that referenced this issue Jun 23, 2017
@jiri-janousek
Release 2.6 - June 18th, 2017
e04bddf 
  * Metadata was updated according to the latest Nuvola SDK
    requirements.
  * Progress bar is fully integrated - it is possible to show track
    position and change it as well. Issue: tiliado/nuvolaplayer#155
  * Volume management is fully integrated - it is possible to show
    volume and change it as well. Issue: tiliado/nuvolaplayer#22
  * The button to add track to favourite tracks was integrated as
    a menu item shown in the menu of Unity launcher, Plank launcher
    and tray icon.

Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
jiri-janousek added a commit that referenced this issue Jun 23, 2017
@jiri-janousek
doc: Document progress bar integration
6f82912 
Issue: #155

Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
jiri-janousek added a commit that referenced this issue Jun 25, 2017
@jiri-janousek
Release 4.5.0 - 24th June, 2017
c9a81ae 
New Features:

  * Nuvola Apps Runtime supports the integration of a progress bar and
    volume management. Web app scripts which use this feature can not
    only provide track length & position and current volume but also
    allow user to change that remotely, e.g. from Media Player GNOME
    Shell extension. At the present, only Deezer and Google Play Music
    scripts use these features but others will follow.
    Issue: #22 Issue: #155
  * If Nuvola Apps Runtime detect a Nvidia graphics card, it checks
    whether the flatpak extension with corresponding graphics driver is
    installed. If it isn't, e.g. because of a bug in GNOME Software,
    an error message is shown to provide the user with installation
    instructions. Issue: #342
  * After a lot of effort, a workaround for the instability of Flash
    plugin was found out and is used until WebKitGTK developers find a
    proper fix. However, it is applied only in flatpak builds because it
    may have negative impact on other WebKitGTK applications otherwise.
    Issue: #354

Bug fixes:

  * Wrong command in desktop launcher was fixed.
    Issue: #348
  * Fix wscript for non-git builds. Issue: tiliado/diorite#16

News for Script Maintainers:

  * `Nuvola.VERSION_MICRO` contains micro version of Nuvola Runtime.
  * `Nuvola.API_VERSION_MAJOR` and `Nuvola.API_VERSION_MINOR` are now
    deprecated aliases of `Nuvola.VERSION_MAJOR`
    and `Nuvola.VERSION_MINOR`.
  * Tutorial was updated to use Nuvola ADK 4.4.
  * Added documentation of web app requirement flags.
  * Added documentation of user agent quirks.
  * New API for progress bar integration.
  * New API for volume management integration.
  * New utility functions `Nuvola.encodeVersion` and
    `Nuvola.checkVersion`.
  * `Nuvola.triggerMouseEvent` and `clickOnElement` support relative
    x & y coordinates.

Under the Hood:

  * New dependencies: libdrm >= 2.2 and libdri2 >= 1.0
  * Nuvola checks whether VDPAU and VA-API drivers are installed and
    prints debugging information to console. It will show error dialog
    in the future though, so make sure the drivers are installed.
    Issue: #280
  * Internal icon loading code was refactored. Legacy icon.png and
    nuvolaplayer3_XXX icons are no longer supported.
    eu.tiliado.NuvolaAppXxx is used everywhere.
    Issue: #353

Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
@jiri-janousek jiri-janousek modified the milestones: 4.6, 4.5, July 2017 Jun 25, 2017
@jiri-janousek jiri-janousek modified the milestones: August 2017, July 2017 Jul 29, 2017
@jiri-janousek jiri-janousek mentioned this issue Apr 20, 2018
Closed
26 tasks
@jiri-janousek
Copy link
Member Author

Closing in favor of #424.

@ghost ghost removed the ready label May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
September 2017
Development

No branches or pull requests
2 participants
@jiri-janousek @tcitworld