Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(TabSwitcher): add guard for null children #484

Merged
merged 1 commit into from
Apr 9, 2019
Merged

fix(TabSwitcher): add guard for null children #484

merged 1 commit into from
Apr 9, 2019

Conversation

sun-tea
Copy link
Contributor

@sun-tea sun-tea commented Apr 9, 2019

  • Feature
  • Fix
  • Enhancement

Description

If there is a null child, the component breaks as child does not have a type.

Todo - Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.

@sun-tea sun-tea added bug Something isn't working need review labels Apr 9, 2019
@sun-tea sun-tea requested a review from spartDev April 9, 2019 08:47
@spartDev spartDev assigned sun-tea and unassigned spartDev Apr 9, 2019
@spartDev spartDev merged commit a6577ee into master Apr 9, 2019
@spartDev spartDev deleted the add-null-check branch April 9, 2019 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spartDev spartDev spartDev approved these changes

Assignees

@sun-tea sun-tea

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sun-tea @spartDev