Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremental builds for the bitstream #167

Merged
merged 6 commits into from
Mar 20, 2024
Merged

Incremental builds for the bitstream #167

merged 6 commits into from
Mar 20, 2024

Conversation

dehanj
Copy link
Member

@dehanj dehanj commented Mar 14, 2024

NOTE: This branch is started from the tkey-builder-3-branch, since the newer tools are needed. This PR should wait to be merged until tkey-builder-3 is merged. tkey-builder-3 is merged, and this branch is rebased on main.

Adding support for incremental builds of the bitstream. Significantly lowers re-build times when changing the UDS and UDI.

@dehanj dehanj requested review from mchack-work and secworks and removed request for mchack-work March 14, 2024 12:58
@dehanj

This comment was marked as resolved.

@dehanj
Copy link
Member Author

dehanj commented Mar 18, 2024

Just rebased this branch on main.

@dehanj
Copy link
Member Author

dehanj commented Mar 19, 2024

The linting is OK now, but this is blocked until we have tkey-builder:3 in place, tkey-builder:2 will not build using the new method.

@dehanj dehanj force-pushed the uds_udi_patch branch 2 times, most recently from 1f45f04 to 7ae4df0 Compare March 20, 2024 09:50
secworks and others added 5 commits March 20, 2024 16:39
By patching the UDS and UDI into an already built bitstream, it is now
not necessary to rebuild the entire build flow when changing the UDS
and the UDI. This lowers re-build times significantly.

Signed-off-by: Joachim Strömbergson <joachim@assured.se>
Signed-off-by: Joachim Strömbergson <joachim@assured.se>
Signed-off-by: Joachim Strömbergson <joachim@assured.se>
Signed-off-by: Joachim Strömbergson <joachim@assured.se>
Copy link
Member

@mchack-work mchack-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like more comments in tools/personalize.py about what it really does but I'm OK with merging now.

@mchack-work mchack-work merged commit 57a6ee2 into main Mar 20, 2024
1 check passed
@mchack-work mchack-work deleted the uds_udi_patch branch March 20, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants