-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incremental builds for the bitstream #167
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dehanj
requested review from
mchack-work and
secworks
and removed request for
mchack-work
March 14, 2024 12:58
This comment was marked as resolved.
This comment was marked as resolved.
Just rebased this branch on main. |
The linting is OK now, but this is blocked until we have tkey-builder:3 in place, tkey-builder:2 will not build using the new method. |
dehanj
force-pushed
the
uds_udi_patch
branch
2 times, most recently
from
March 20, 2024 09:50
1f45f04
to
7ae4df0
Compare
By patching the UDS and UDI into an already built bitstream, it is now not necessary to rebuild the entire build flow when changing the UDS and the UDI. This lowers re-build times significantly. Signed-off-by: Joachim Strömbergson <joachim@assured.se>
Signed-off-by: Joachim Strömbergson <joachim@assured.se>
Signed-off-by: Joachim Strömbergson <joachim@assured.se>
Signed-off-by: Joachim Strömbergson <joachim@assured.se>
mchack-work
force-pushed
the
uds_udi_patch
branch
from
March 20, 2024 15:44
6d8be23
to
4154239
Compare
mchack-work
force-pushed
the
uds_udi_patch
branch
from
March 20, 2024 16:20
4154239
to
57a6ee2
Compare
mchack-work
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like more comments in tools/personalize.py about what it really does but I'm OK with merging now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This branch is started from thetkey-builder-3
-branch, since the newer tools are needed. This PR should wait to be merged untiltkey-builder-3
is merged.tkey-builder-3
is merged, and this branch is rebased on main.Adding support for incremental builds of the bitstream. Significantly lowers re-build times when changing the UDS and UDI.