Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: add healthchecks on cluster creation #134

Merged
merged 1 commit into from
Sep 23, 2021
Merged

cluster: add healthchecks on cluster creation #134

merged 1 commit into from
Sep 23, 2021

Conversation

nicks
Copy link
Member

@nicks nicks commented Sep 23, 2021

Hello @nicks,

Please review the following commits I made in branch nicks/issue131:

7ac676d (2021-09-23 00:31:12 -0400)
cluster: add healthchecks on cluster creation
fixes #131

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks nicks merged commit 73fa3b7 into main Sep 23, 2021
@nicks nicks deleted the nicks/issue131 branch September 23, 2021 15:16
@TimothyLoyer
Copy link

@nicks is this going to be released as part of 0.5.6?

@nicks
Copy link
Member Author

nicks commented Sep 23, 2021

@TimothyLoyer yep! Cutting a release now. needed to do some other dependency upgrading to address a security alert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ctlptl stops waiting for Docker Desktop to be ready before Kubernetes is actually ready
2 participants