New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove special characters from title when searching. fixes https://github.com/windmilleng/exterminator/issues/6 #7

Merged

nicks merged 1 commit into master from nicks/specialchars

Apr 10, 2020

Member

nicks commented Apr 10, 2020

Hello @maiamcc,

Please review the following commits I made in branch nicks/specialchars:

52caadc (2020-04-10 10:13:47 -0400)
remove special characters from title when searching. fixes #6

Code review reminders, by giving a LGTM you attest that:

Commits are adequately tested
Code is easy to understand and conforms to style guides
Incomplete code is marked with TODOs
Code is suitably instrumented with logging and metrics


          remove special characters from title when searching. fixes #6

52caadc

nicks requested a review from maiamcc

April 10, 2020 14:14

maiamcc approved these changes

View reviewed changes

Contributor

maiamcc left a comment

nice! ty

nicks merged commit ff68159 into master

nicks deleted the nicks/specialchars branch

April 10, 2020 17:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet