Fix: equipment related crash #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
howdy, my brother is crashing all the time. We constantly share equipments, because I'm the smither and he's the enchanter. Would it make sense that we try this build? What's the estimated release date for this to be included in a stable release? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExtraDataList seems to be deallocated on a different thread sometimes. This seems to happen right between us fetching the inventory delta and locking the list. Not sure how Bethesda manages to avoid this, but calling the native UnequipAll function is safer than doing it manually anyway.
One user reported significantly fewer crashes when using this branch, possibly cutting down on a significant amount of crashing for other users as well.