Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong scope for JUnit 4 dependency #1

Closed
pmwmedia opened this issue Mar 6, 2019 · 3 comments
Closed

Wrong scope for JUnit 4 dependency #1

pmwmedia opened this issue Mar 6, 2019 · 3 comments
Assignees
Labels

Comments

@pmwmedia
Copy link

pmwmedia commented Mar 6, 2019

The Maven artifact clocks-testing 1.0.1070 declares JUnit 4 as compile dependency: http://central.maven.org/maven2/com/timgroup/clocks-testing/1.0.1070/clocks-testing-1.0.1070.pom

Actually, JUnit 4 is only used for testing. Therefore, I suggest to change the scope of JUnit 4 from compile to test. I use JUnit 5 for my JUnit tests, and I would prefer, if clocks-testing would not add JUnit 4 unnecessarily to the classpath.

flicken added a commit that referenced this issue Mar 7, 2019
Prerequisite for #1, but still needs a release to Maven Central.
@araqnid araqnid self-assigned this Mar 14, 2019
@araqnid araqnid added the bug label Mar 14, 2019
@araqnid
Copy link
Member

araqnid commented Mar 14, 2019

joda-testing has the same problem - that does in fact contain a JUnit4 rule, which should maybe be moved off into a separate artifact.

Anyway, version 1.0.1088 with this issue fixed is on its way to Maven Central now.

@pmwmedia
Copy link
Author

That is great :) Thank you!

@araqnid
Copy link
Member

araqnid commented Mar 14, 2019

@araqnid araqnid closed this as completed Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants