Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SLACK_TOKEN from environment of containers #43

Open
rstata opened this issue Jan 10, 2018 · 0 comments
Open

Remove SLACK_TOKEN from environment of containers #43

rstata opened this issue Jan 10, 2018 · 0 comments

Comments

@rstata
Copy link

rstata commented Jan 10, 2018

The Slack token used by Limbo is passed via the SLACK_TOKEN environment variable. When running in ECS, this variable can be inspected with the ECS Web UI. A better approach would be to store the token in S3 or some other storage service that provides access control, and then use the IAM role provided by issue #22 to gain access to the token. (This would require a change to the initialization code of Limbo to provide an alternative mechanism for loading the Slack token. This alternative mechanism should be available through some sort of "feature flag," with the current environment-based initialization configured as the default.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant