Remove AWS keys from limbo container environment #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pending discussion and merge conflict resolution. |
|
Fixed the merge conflict. Still need to discuss. |
davidchaiken
changed the title
|
Closed in favor of PR #36 (which rebases the changes). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22.
Before merging, we should think through how to present this to students. It might be better to leave this unmerged going into the class. During the lecture on security, we can show how the AWS keys as well as the Slack keys have been compromised. We can then walk them through the IAM "role" mechanism and explain why it was invented to solve this problem. We can then merge this patch in to fix the AWS/Bootstrapping problem, and ask the students to come up with a means of getting SLACK_TOKEN from S3.