Set protocol to HTTPs; set path to /docs #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, yeah that’s a bit of a hassle, that the path contains a subfolder. I’d go the easier way and prepend all assets with the baseURL, which is available as a site variable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gchtr — I think this PR should finish it off.
A live (but broken version) of the docs are live at:
https://timber.github.io/docs/
... It looked like some things were failing to load b/c of HTTP vs HTTPs and correct depth of the
/docsfolder. I did some tweaks locally (thanks for explaining how to set a local baseURL, btw) — which I think this PR will resolve. Take a look and see if there's any last things that I missed (or messed up). From there we can make this live and then redirect the old Slate-based docs to this new-and-improved version 🎉