feat(new sink): Initial papertrail sink
#1835
Conversation
Signed-off-by: Lucio Franco <luciofranco14@gmail.com>
Signed-off-by: Lucio Franco <luciofranco14@gmail.com>
src/sinks/papertrail.rs
Outdated
| } | ||
| } | ||
|
|
||
| fn encode_event(mut event: crate::Event, pid: u32, encoding: &Encoding) -> Option<Bytes> { |
There was a problem hiding this comment.
Seems very reasonable for this to return a Result no?
There was a problem hiding this comment.
since our sinks don't return errors we are forced to handle errors within the sink. I have yet to see an encoding panic in any of our sinks and we use this option trick.
|
Do you have a test account I can use, or should I make one? :) |
|
@Hoverbear you probably want to make one |
|
Text works fine actually, seems it was just that I missed it. |
.meta/sinks/papertrail.toml
Outdated
| examples = ["logs.papertrailapp.com:12345"] | ||
| description = "The endpoint to stream logs to." | ||
|
|
||
| [sinks.papertrail.options.encoding] |
There was a problem hiding this comment.
This should default to json.
There was a problem hiding this comment.
I am not following the reason to make this a default?
There was a problem hiding this comment.
In #1915 we removed defaults where there was more than one option according to advice from @binarylogic
There was a problem hiding this comment.
It should be a case by case basis. Clearly Honeycomb should receive structured data. It doesn’t even have full text searching capabilities...
There was a problem hiding this comment.
This isn't honeycomb? To me here it totally makes sense to let the user choose since papertrail doesn't takes advantage of the message field in syslog.
According to @Hoverbear we are no longer settings defaults? #1832 (comment)
There was a problem hiding this comment.
Ha, I'm losing my mind. Sure, I think for papertrail it makes sense to require it. For Honeycomb not so much.
|
@LucioFranco This PR desires your attention. :) |
Signed-off-by: Lucio Franco <luciofranco14@gmail.com>
Signed-off-by: Lucio Franco <luciofranco14@gmail.com>
This implements a basic papertrail sink that sends logs via syslog rfc3164.
Closes #1509