Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement(remap transform): add parse_aws_vpc_flow_log function #5504

Merged
merged 11 commits into from
Dec 18, 2020
Merged

enhancement(remap transform): add parse_aws_vpc_flow_log function #5504

merged 11 commits into from
Dec 18, 2020

Conversation

fanatid
Copy link
Contributor

@fanatid fanatid commented Dec 11, 2020

Closes #5366

@fanatid
enhancement(remap transform): add parse_aws_vpc_flow function
9649e95 
Signed-off-by: Kirill Fomichev <fanatid@ya.ru>
@fanatid fanatid added the domain: vrl Anything related to the Vector Remap Language label Dec 11, 2020
@fanatid fanatid self-assigned this Dec 11, 2020
@JeanMertz JeanMertz mentioned this pull request Mar 28, 2023
Open
@fanatid
Merge remote-tracking branch 'upstream/master' into remap-add-parse-a…
be2e3ce 
…ws-vpc-flow
@fanatid
add to CODEOWNERS
352f467 
Signed-off-by: Kirill Fomichev <fanatid@ya.ru>
@fanatid
fix null values in docs
fbd35b3 
Signed-off-by: Kirill Fomichev <fanatid@ya.ru>
@fanatid fanatid marked this pull request as ready for review December 16, 2020 14:37
StephenWakely
StephenWakely requested changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@StephenWakely StephenWakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, looks nice.

Just one thing, it needs a behaviour test (https://github.com/timberio/vector/blob/master/tests/behavior/transforms/remap.toml).

These files are being moved into a separate crate in #5522, so we need to make sure this doesn't get lost in the move. The behaviour test will help with that!

@fanatid
Copy link
Contributor Author

fanatid commented Dec 17, 2020

@jszwedko should we rename this function to parse_aws_vpc_flow_log (as parse_aws_alb_log from #5489)?

StephenWakely
StephenWakely approved these changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@StephenWakely StephenWakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@fanatid
Merge remote-tracking branch 'upstream/master' into remap-add-parse-a…
d495006 
…ws-vpc-flow
@fanatid
fix tests
78121ab 
Signed-off-by: Kirill Fomichev <fanatid@ya.ru>
jszwedko
jszwedko reviewed Dec 17, 2020
View reviewed changes
Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should call this parse_aws_vpc_flow_log for parity with parse_aws_alb_log? Otherwise this looks good to me!

@fanatid fanatid changed the title enhancement(remap transform): add parse_aws_vpc_flow function enhancement(remap transform): add parse_aws_vpc_flow_log function Dec 18, 2020
@fanatid fanatid merged commit 5488be0 into master Dec 18, 2020
@fanatid fanatid deleted the remap-add-parse-aws-vpc-flow branch December 18, 2020 13:03
@fanatid fanatid mentioned this pull request Jan 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jszwedko jszwedko jszwedko left review comments

@StephenWakely StephenWakely StephenWakely approved these changes

@JeanMertz JeanMertz Awaiting requested review from JeanMertz

Assignees

@fanatid fanatid

Labels
domain: vrl Anything related to the Vector Remap Language
Projects
None yet
Milestone
2020-12-07: Nanite Repair System
Development

Successfully merging this pull request may close these issues.

New parse_aws_vpc_flow_log
4 participants
@fanatid @StephenWakely @jszwedko @JeanMertz