[diff view] Cannot [hhh]unk in a meaningful speed
#1104
Comments
kaste
added a commit
to kaste/GitSavvy
that referenced
this issue
Feb 14, 2019
We must ensure that hitting 'h' very fast does run completely ordered, and
always waits for 'gs_diff_refresh' to complete. ('gs_diff_refresh' updates our
model.)
Please NOTE that running a command from the worker will still run that command
on the main thread. T.i. `set_timeout_async(lambda: view.run_command("refresh"))`
is misleading and a footgun because the "refresh" command here will still start
on the main thread. We basically just await the worker and then put a
task/command on the main worker queue.
Fixes timbrel#1104
stoivo
pushed a commit
that referenced
this issue
Sep 11, 2019
We must ensure that hitting 'h' very fast does run completely ordered, and
always waits for 'gs_diff_refresh' to complete. ('gs_diff_refresh' updates our
model.)
Please NOTE that running a command from the worker will still run that command
on the main thread. T.i. `set_timeout_async(lambda: view.run_command("refresh"))`
is misleading and a footgun because the "refresh" command here will still start
on the main thread. We basically just await the worker and then put a
task/command on the main worker queue.
Fixes #1104
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If you hit 'hhh' to hunk 3 hunks in a row fast, you likely get a 'cannot apply patch' error from git.
Basically, view and state are out of sync here. Typically 'hunking' must be blocking on the main thread. Or: 'hunking' must update the view optimistically. Since the latter is almost impossible to do right, we should use the 'blocking' strategy.
The text was updated successfully, but these errors were encountered: