Pedantic commit #849
Merged
Pedantic commit #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stoivo
force-pushed
the
pedantic_commit
branch
2 times, most recently
from
9749402
to
91109f8
Compare
randy3k
reviewed
Feb 10, 2018
syntax/make_commit.sublime-settings
Outdated
| @@ -14,5 +14,4 @@ | |||
| "gutter": true, | |||
| "line_numbers": true, | |||
| "word_wrap": true, | |||
stoivo
force-pushed
the
pedantic_commit
branch
from
91109f8
to
b90d783
Compare
|
Thanks. I think this is a sensible default. And if anyone hates it. They can change it or turn it of. |
asfaltboy
requested changes
Feb 10, 2018
core/commands/commit.py
Outdated
| self.view = view | ||
| self.first_line_limit = savvy_settings.get('pedantic_commit_first_line_length') | ||
| self.body_line_limit = savvy_settings.get('pedantic_commit_message_line_length') | ||
| self.warrning_size = savvy_settings.get('pedantic_commit_warning_length') |
There was a problem hiding this comment.
Typo in warrning_size; should this be warning_size, or even warning_length ?
core/commands/commit.py
Outdated
|
|
||
| first_line = self.view.lines(sublime.Region(0,0))[0] | ||
| length = first_line.b - first_line.a | ||
| if self.first_line_limit < length: |
There was a problem hiding this comment.
I think the condition is clearer like this:
if length > self.first_line_limit:
core/commands/commit.py
Outdated
| if self.first_line_limit < length: | ||
| warning_lines.append(sublime.Region( | ||
| first_line.a + self.first_line_limit, | ||
| min(first_line.a+self.first_line_limit+self.warrning_size, first_line.b))) |
There was a problem hiding this comment.
I get vexed by the inconsistent spacing around the plus (+) operator... can we please always have space on either side of plusses?
stoivo
force-pushed
the
pedantic_commit
branch
from
b90d783
to
c0085fa
Compare
asfaltboy
approved these changes
Feb 11, 2018
|
Thanks. I will try to finish #813 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
invalid.deprecated.line-too-long.git-commitwhereinvalidis the same scope as SublimeLinter uses to is should be coverd by all Themesfix #41
fix #423