Fix BufferManager bounds checking logic #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timcanham
approved these changes
Jul 20, 2021
timcanham
pushed a commit
that referenced
this pull request
Aug 2, 2021
* Create tutorial-support.yml * Update tutorial-support.yml GpsApp tutorial to be pulled for build test and submodules to be pulled recursively * Implementation of tutorial workflow * typo in repo address * Added missing github action file * Changed workflow path * Changed dir paths * Work around for workflow * work around * troubleshooting * troubleshoot * troubleshoot * Performance update * Path correction * troubleshoot * Dockerfile correction * path change * path change * path fix * path fix * path fix * path fix * paht fix * Revert to changes * Completed workflow for tutorial support * troubleshoot * Build path error * Optimization of workflow * Path fix * Path fix * Path fix #1 * path fix #2 * path check * Workflow test * Workflow test #2 * Added logging feature * Logs Troubleshoot * Typo fix * Troubleshoot #1 * Troubleshoot #2 * Corrected typo on path * Troubleshoot #3 * Troubleshoot #4 * Troubleshoot #5 * Removed log archive feature * Changed repo path to conform pull request merge
timcanham
pushed a commit
that referenced
this pull request
Aug 25, 2021
* Create tutorial-support.yml * Update tutorial-support.yml GpsApp tutorial to be pulled for build test and submodules to be pulled recursively * Implementation of tutorial workflow * typo in repo address * Added missing github action file * Changed workflow path * Changed dir paths * Work around for workflow * work around * troubleshooting * troubleshoot * troubleshoot * Performance update * Path correction * troubleshoot * Dockerfile correction * path change * path change * path fix * path fix * path fix * path fix * paht fix * Revert to changes * Completed workflow for tutorial support * troubleshoot * Build path error * Optimization of workflow * Path fix * Path fix * Path fix #1 * path fix #2 * path check * Workflow test * Workflow test #2 * Added logging feature * Logs Troubleshoot * Typo fix * Troubleshoot #1 * Troubleshoot #2 * Corrected typo on path * Troubleshoot #3 * Troubleshoot #4 * Troubleshoot #5 * Removed log archive feature * Changed repo path to conform pull request merge * Test run #1 * test #2 * test #3 * added branch for workflow test * test #4 * test #4 * test #5 * test #6 * Test #7 * test #8 * test #8 * Test #9 * Test #9 * Test #10 * Test #11 * Test #12 * Test #13 * Test #14 * Test #15 * Test #16 * Test #17 * Test #18 * Test #20 * Test nasa#21 * Test nasa#22 * Test nasa#23 * Test nasa#24 * Test nasa#25 * Split test files * Split tests #2 * Added executable permissions * Delete RPI.bash * Delete Ref.bash * Delete Framework.bash * exe files * Make Framework.bash executable * Make RPI.bash and Ref.bash executable * Test nasa#26 * Test nasa#27 * Test nasa#28 * Attached Integration test to Ref test * Test nasa#29 * Test nasa#30 * Test nasa#31 * Test nasa#32 * Test nasa#33 * Test nasa#34 * Test nasa#35 * Test nasa#35 * Test nasa#37 * Test nasa#38 * Test nasa#39 * Test nasa#40 * Test nasa#41 * Test nasa#42 * Test nasa#43 * Test nasa#43 * Test nasa#44 * Test nasa#45 * Cleaned up files to remove commented code * Remove CI test branch from workflow * Incorporated comments for PR * Modified path for framework job test * Incoporate reviewer comment for PR * Incoporated reviewer comment for PR * Was using incorrect directory for the test * Revised args call for jobs * Passing args #1 * Define entrypoint directly from workflow * Changed entrypoint method * Changed entrypoint method #2 * Corrected test path * Syntax correction * Path Test #1 * Path test #2 * Path Test #4 * Path Test $5 * Test Path #6 * Path Test #6 * Path Test #7 * Path Test #8 * Refactored scripts to remove master.bash * Corrected test path * Fixed log problems * Entrypoint alternative * Bypassed master.bash file * Added line for better CI error messages
timcanham
pushed a commit
that referenced
this pull request
Aug 25, 2021
Correct some spelling mistakes
timcanham
pushed a commit
that referenced
this pull request
May 30, 2023
Merge pull request #17 from gjwatney/microfsexp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the failure case where the buffer size requested is equal to the buffer size allocated.
Additionally, an assert is made more verbose, to add visibility when it fails.