Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle more gmail links within gmail-desktop #379

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

brendanmeyer
Copy link

  • fix for 348, as well as other improvements for handling gmail links
  • opens "View entire message" and print views
  • downloads "download original" without browser
  • even from child windows
  • added context menu to child windows

I think this one will need a little more testing, as I am unsure how it works with multiple accounts
also I wasn't sure of the purpose of line 73 in src/main/account-views/index.ts

- fix 348
- opens "View entire message" and print views
- downloads "download orignal" without browser
- even from sub windows
- added context menu to sub windows
@brendanmeyer
Copy link
Author

In regards to line 73, having this line uncommented, made secondary child windows hidden behind the main window

@brendanmeyer
Copy link
Author

should fix #385 as well

@JJWatMyself
Copy link

@brendanmeyer Any chance we can also have window opens without browser for:

Contacts
Calendar
Keep
Tasks

Described here: #378

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants