Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PropisePool can resolve result array as Promise.all does #52

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fivagod
Copy link

@fivagod fivagod commented Dec 13, 2017

Promise.all can participate in chain like

Promise.all( DataArray.map(MakeSomething:Promise)).then(
        results => {
          return Promise.all(results.map(MakeSomethingAlso));
        }
      ).then(
        results => {
          return Promise.all(results.map(MakeSomethingAlso2:));
        }
      )

PropisePool can't because doesn't resolve any results

@AppVeyorBot
Copy link

Build es6-promise-pool 181 failed (commit f30f906948 by @fivagod)

@timdp
Copy link
Owner

timdp commented Mar 24, 2018

Thanks. I don't think it's a good idea to have this by default though. See #51 for background.

I'd probably accept a PR that makes it opt-in. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants