Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warning when using sunburstOutput with shiny 1.7.4 (latest CRAN) #115

Closed
ismirsehregal opened this issue Feb 2, 2023 · 3 comments
Closed

Comments

@ismirsehregal
Copy link

ismirsehregal commented Feb 2, 2023

When using sunburstOutput in a shiny app (latest CRAN version) the following warning is thrown after closing the app:

Warning message:

bindFillRole() only works on htmltools::tag() objects (e.g., div(), p(), etc.), not objects of type 'shiny.tag.list'.

Example (slightly modified version of this):

library(shiny)
library(sunburstR)

sequences <- read.csv(
  system.file("examples/visit-sequences.csv", package = "sunburstR"),
  header = FALSE,
  stringsAsFactors = FALSE
)

server <- function(input, output, session) {
  output$sunburst <- renderSunburst({
    #invalidateLater(1000, session)
    sequences <-
      sequences[sample(nrow(sequences), 1000, replace = TRUE), ]
    add_shiny(sunburst(sequences))
  })
  
  selection <- reactive({
    input$sunburst_mouseover
  })
  
  output$selection <- renderText(selection())
}

ui <- fluidPage(sidebarLayout(sidebarPanel(),
                              # plot sunburst
                              mainPanel(
                                sunburstOutput("sunburst"),
                                textOutput("selection")
                              )))

shinyApp(ui = ui, server = server)
@hammerPC
Copy link

hammerPC commented Feb 2, 2023 via email

@timelyportfolio
Copy link
Owner

@ismirsehregal thanks so much for the report. I believe we can fix pretty easily by removing the enclosing tagList. I have committed the change and am submitting to CRAN. Please let me know if you experience any other challenges.

@ismirsehregal
Copy link
Author

I can confirm the warning is gone after using the dev version. Thanks for your swift investigation @timelyportfolio!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants