Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor JS code to separate modules #37

Open
1 of 5 tasks
timelyportfolio opened this issue Jun 8, 2017 · 0 comments
Open
1 of 5 tasks

refactor JS code to separate modules #37

timelyportfolio opened this issue Jun 8, 2017 · 0 comments

Comments

@timelyportfolio
Copy link
Owner

timelyportfolio commented Jun 8, 2017

After converting to d3v4, I would like to modularize the JS code to resemble Let's Make a D3 Plugin. As an example of this, I have done d3horizonR. d3horizonR is not perfect, but demonstrates how the JS lives in its own separate directory ignored by the R pkg. The JS gets processed, built, and compiled and then moves to the inst/htmlwidgets folder for use by the R package. The advantage is we can stick to a "modern" typical JS build and test workflow.

See leaflet as another example.

Potential Modules

A quick round of code analysis reveals some clear module opportunities.

  • HTMLWidgets module, but this should be separate from the main JavaScript build
  • Vis layout module
  • Breadcrumb module
  • Legend module
  • Hierarchy builder and helper module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant