Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce size of vendor.js #78

Open
aendra-rininsland opened this issue Jun 23, 2015 · 5 comments
Open

Reduce size of vendor.js #78

aendra-rininsland opened this issue Jun 23, 2015 · 5 comments
Milestone
1.1.1

Comments

@aendra-rininsland
Copy link
Contributor

dist/vendor.js is like 1.8mb ungzipped. This is ridiculously big.
@aendra-rininsland aendra-rininsland added this to the 1.1.0 milestone Jun 23, 2015
@aendra-rininsland
Copy link
Contributor Author

I've updated the Gruntfile a bit so that it doesn't include the Bootstrap JS deps, which shaved off 0.1mb. The bigger issue is that all the core Angular deps are being served from vendor.js and not CDN; see yeoman/generator-angular#955.

@aendra-rininsland
Copy link
Contributor Author

This is also due to Handsontable being absolutely massive, and not helped by the fact they bundle dependencies in their dist versions. See handsontable/handsontable#2582.

Granted...
screen shot 2015-06-23 at 16 16 29

(Valid point to @MattieTK.)

aendra-rininsland pushed a commit that referenced this issue Jun 23, 2015
Improving dist/scripts/vendor.js size. See #78.
d543c93
@budnix
Copy link

budnix commented Jun 24, 2015

Hi, Thanks for bug report at handsontable/handsontable#2582. Patch will be released tommorow with Handsontable 0.15.1. Our team still have in mind to keep library as small as possible that is why we try to modularize the code to easy detach/attach fragments of code to reduce final file size. Maybe custom build will interest you http://docs.handsontable.com/0.15.0/tutorial-custom-build.html#page-customizing

@aendra-rininsland
Copy link
Contributor Author

@budnix Cool! Many thanks! HOT Builder definitely looks like something I could use, will take a look!

@aendra-rininsland aendra-rininsland modified the milestones: 1.1.1, 1.1.0 Oct 27, 2015
@aendra-rininsland
Copy link
Contributor Author

Kicking to next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.1
Development

No branches or pull requests
2 participants
@aendra-rininsland @budnix