-
Notifications
You must be signed in to change notification settings - Fork 886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrading from PG 11 to 12 does not work using pg_upgrade #1844
Comments
I've hit basically the same error doing a pg_upgrade from PG10 to PG11 with TimescaleDB 1.6.1
|
I managed to work past my issue by using |
I had the same suspicion that the |
Folks, thanks for this back-and-forth. We are investigating, but keep the insights and observations coming! |
Looking through the code and trying multiple ways to reproduce it I still do not see why the upgrade as described above fails. The procedure I did was as described above, but repeating it below with details about what I did so that others can check. SummaryTo run an upgrade, it is necessary to
The procedures The binary I manage to get the error message ( Reproduction stepsWhat I did was: Set up the PG11 server:
Create a PG12 server:
Do the upgrade:
Environment variables set are:
(Function |
Thank you so much @mkindahl for the thorough investigation. I wish I could add more to this, but at least I verified in pg_upgrade's
Let me know if there is anything else I can check. |
One more thing I tried without luck was to set |
@pehlert Can you turn on statement logging (
After digging through the code, it seems like database-specific settings are dumped with If |
Hi @mkindahl , again thank you so much for taking care of this and the brilliant investigation. Your assumption is spot on, this is the relevant part of the log:
I can also confirm that a |
@pehlert Thank you for testing this, it confirmed my suspicion and we have a patch that fixes this specific case of the issue. However, given how option processing works, it is not a very solid approach to rely on |
If a binary upgrade is in progress (when using `pg_upgrade`) the per-database setting of `timescaledb.restoring` can be included in the dump, which causes `pg_upgrade` to fail. This commit fixes this by checking the global variable `IsBinaryUpgrade` and not refreshing cache if we are in the middle of doing a binary upgrade. Fixes timescale#1844
If a binary upgrade is in progress (when using `pg_upgrade`) the per-database setting of `timescaledb.restoring` can be included in the dump, which causes `pg_upgrade` to fail. This commit fixes this by checking the global variable `IsBinaryUpgrade` and not refreshing cache if we are in the middle of doing a binary upgrade. Fixes timescale#1844
If a binary upgrade is in progress (when using `pg_upgrade`) the per-database setting of `timescaledb.restoring` can be included in the dump, which causes `pg_upgrade` to fail. This commit fixes this by checking the global variable `IsBinaryUpgrade` and not refreshing cache if we are in the middle of doing a binary upgrade. Fixes timescale#1844
Let me know if I can support in testing this. Unfortunately as these are quite old datasets (I think we started with TSDB 1.3) I cannot pinpoint what could have set the parameter on the database in the first place. |
If a binary upgrade is in progress (when using `pg_upgrade`) the per-database setting of `timescaledb.restoring` can be included in the dump, which causes `pg_upgrade` to fail. This commit fixes this by checking the global variable `IsBinaryUpgrade` and not refreshing cache if we are in the middle of doing a binary upgrade. Fixes #1844
Precisely the reason to remove the option. It is not feasible to expect anybody to track down rouge settings of I created issue #1878 to track this. |
If a binary upgrade is in progress (when using `pg_upgrade`) the per-database setting of `timescaledb.restoring` can be included in the dump, which causes `pg_upgrade` to fail. This commit fixes this by checking the global variable `IsBinaryUpgrade` and not refreshing cache if we are in the middle of doing a binary upgrade. Fixes #1844
Hi all,
I tried to upgrade from PG 11 to PG 12.
What I did was:
pg_upgrade -O "-c timescaledb.restoring='on'"
(data dirs are set using ENV vars)What it returns:
The text was updated successfully, but these errors were encountered: