Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify msvc compat stuff #6937

Merged
merged 1 commit into from
May 25, 2024
Merged

Simplify msvc compat stuff #6937

merged 1 commit into from
May 25, 2024

Conversation

svenklemm
Copy link
Member

@svenklemm svenklemm commented May 19, 2024

Some of the fixes are no longer needed and it is completely fixed
upstream in PG15+.

Disable-check: loader-change
Disable-check: force-changelog-file

Copy link

codecov bot commented May 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.64%. Comparing base (59f50f2) to head (7830c5e).
Report is 177 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6937      +/-   ##
==========================================
+ Coverage   80.06%   81.64%   +1.57%     
==========================================
  Files         190      198       +8     
  Lines       37181    36849     -332     
  Branches     9450     9631     +181     
==========================================
+ Hits        29770    30086     +316     
+ Misses       2997     2881     -116     
+ Partials     4414     3882     -532     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@svenklemm svenklemm changed the title Remove msvc compat stuff Simplify msvc compat stuff May 20, 2024
@svenklemm svenklemm self-assigned this May 20, 2024
@svenklemm svenklemm marked this pull request as ready for review May 20, 2024 02:27
@svenklemm svenklemm added the tech-debt Needs refactoring and improvement tasks related to the source code and its architecture. label May 20, 2024
Copy link
Contributor

@antekresic antekresic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@svenklemm svenklemm force-pushed the msvc branch 17 times, most recently from 655c7ba to c57e17d Compare May 25, 2024 06:06
@svenklemm svenklemm force-pushed the msvc branch 11 times, most recently from c34875d to 7830c5e Compare May 25, 2024 13:44
Some of the fixes are no longer needed and it is completely fixed
upstream in PG15+.
@svenklemm svenklemm merged commit 4aa5800 into timescale:main May 25, 2024
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt Needs refactoring and improvement tasks related to the source code and its architecture.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants