-
Notifications
You must be signed in to change notification settings - Fork 882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix segfault on CAggs with multiple JOINs #7146
Merged
fabriziomello
merged 2 commits into
timescale:main
from
fabriziomello:cagg_fix_segfault_with_multiple_joins
Jul 23, 2024
Merged
Fix segfault on CAggs with multiple JOINs #7146
fabriziomello
merged 2 commits into
timescale:main
from
fabriziomello:cagg_fix_segfault_with_multiple_joins
Jul 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziomello
force-pushed
the
cagg_fix_segfault_with_multiple_joins
branch
from
July 22, 2024 21:53
971c6ed
to
98d6365
Compare
svenklemm
approved these changes
Jul 23, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7146 +/- ##
==========================================
+ Coverage 80.06% 81.77% +1.70%
==========================================
Files 190 203 +13
Lines 37181 37960 +779
Branches 9450 9845 +395
==========================================
+ Hits 29770 31042 +1272
+ Misses 2997 2965 -32
+ Partials 4414 3953 -461 ☔ View full report in Codecov by Sentry. |
fabriziomello
force-pushed
the
cagg_fix_segfault_with_multiple_joins
branch
from
July 23, 2024 14:53
f5ccd4c
to
1e29cd1
Compare
svenklemm
approved these changes
Jul 23, 2024
akuzm
reviewed
Jul 23, 2024
akuzm
approved these changes
Jul 23, 2024
Creating or changing to realtime a Continuous Aggregate with multiple joins was leading to a segfault. Fixed it by dealing properly with the `varno` when creating the `Quals` for the union view in realtime mode. Also get rid of some left over when we relaxed the CAggs join restrictions in timescale#7111.
Refactored the Hierarchical Continuous Aggregate regression tests including more columns in JOIN tests and also added an `ORDER BY` clause to definition to avoid flake tests when querying and show the result rows.
fabriziomello
force-pushed
the
cagg_fix_segfault_with_multiple_joins
branch
from
July 23, 2024 17:59
22902ae
to
57f7b71
Compare
Automated backport to 2.15.x not done: cherry-pick failed. Git status
|
timescale-automation
added
the
auto-backport-not-done
Automated backport of this PR has failed non-retriably (e.g. conflicts)
label
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport-not-done
Automated backport of this PR has failed non-retriably (e.g. conflicts)
bug
continuous_aggregate
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating or changing to realtime a Continuous Aggregate with multiple joins was leading to a segfault.
Fixed it by dealing properly with the
varno
when creating theQuals
for the union view in realtime mode.Also get rid of some left over when we relaxed the CAggs join restrictions in #7111.
Disable-check: force-changelog-file
Disable-check: commit-count