Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename {enable|disable}_column_stats API #7157

Merged

Conversation

fabriziomello
Copy link
Contributor

@fabriziomello fabriziomello commented Jul 25, 2024

For better understanding we've decided to rename the public API from {enable|disable}_column_stats to {enable|disable}_chunk_skipping.

Disable-check: force-changelog-file
Disable-check: commit-count

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.74%. Comparing base (59f50f2) to head (98874e0).
Report is 270 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7157      +/-   ##
==========================================
+ Coverage   80.06%   81.74%   +1.67%     
==========================================
  Files         190      203      +13     
  Lines       37181    37975     +794     
  Branches     9450     9847     +397     
==========================================
+ Hits        29770    31042    +1272     
+ Misses       2997     2980      -17     
+ Partials     4414     3953     -461     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fabriziomello fabriziomello enabled auto-merge (rebase) July 26, 2024 00:16
@@ -51,21 +51,21 @@ INSERT INTO sample_table VALUES (:'start_date'::timestamptz, 16, 14.6554, 47, 'n
-- Non-int, date, timestamp cannot be specified as a min/max ranges for now
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the test file name itself as chunk_column_stats seem alright? Would it need chunk_skipping in the name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make it simple and fast I've decided to only rename the public API.

Copy link
Contributor

@pallavisontakke pallavisontakke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would we need changes to the file https://github.com/timescale/timescaledb/blob/main/.unreleased/pr_7020 ? It right now says:
Implements: #7020: Add support for the chunk column statistics tracking.

@pallavisontakke pallavisontakke added force-auto-backport Automatically backport this PR or fix of this issue, even if it's not marked as "bug" and removed bug labels Jul 26, 2024
@fabriziomello
Copy link
Contributor Author

Would we need changes to the file https://github.com/timescale/timescaledb/blob/main/.unreleased/pr_7020 ? It right now says: Implements: #7020: Add support for the chunk column statistics tracking.

At this point would be better to change the release PRs.

For better understanding we've decided to rename the public API from
`{enable|disable}_column_stats` to `{enable|disable}_chunk_skipping`.
@fabriziomello fabriziomello merged commit a4a023e into timescale:main Jul 26, 2024
38 of 39 checks passed
@timescale-automation
Copy link

Automated backport to 2.15.x not done: cherry-pick failed.

Git status

HEAD detached at origin/2.15.x
You are currently cherry-picking commit 554957cc1.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   tsl/test/expected/chunk_column_stats-16.out
	modified:   tsl/test/sql/.gitignore

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   tsl/test/expected/chunk_column_stats-14.out
	deleted by us:   tsl/test/expected/chunk_column_stats-15.out
	both modified:   tsl/test/sql/CMakeLists.txt
	deleted by us:   tsl/test/sql/chunk_column_stats.sql.in


Job log

@timescale-automation timescale-automation added the auto-backport-not-done Automated backport of this PR has failed non-retriably (e.g. conflicts) label Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport-not-done Automated backport of this PR has failed non-retriably (e.g. conflicts) compression force-auto-backport Automatically backport this PR or fix of this issue, even if it's not marked as "bug"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants