-
Notifications
You must be signed in to change notification settings - Fork 882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename {enable|disable}_column_stats API #7157
Rename {enable|disable}_column_stats API #7157
Conversation
b3c6870
to
6e60082
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7157 +/- ##
==========================================
+ Coverage 80.06% 81.74% +1.67%
==========================================
Files 190 203 +13
Lines 37181 37975 +794
Branches 9450 9847 +397
==========================================
+ Hits 29770 31042 +1272
+ Misses 2997 2980 -17
+ Partials 4414 3953 -461 ☔ View full report in Codecov by Sentry. |
@@ -51,21 +51,21 @@ INSERT INTO sample_table VALUES (:'start_date'::timestamptz, 16, 14.6554, 47, 'n | |||
-- Non-int, date, timestamp cannot be specified as a min/max ranges for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the test file name itself as chunk_column_stats
seem alright? Would it need chunk_skipping
in the name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make it simple and fast I've decided to only rename the public API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would we need changes to the file https://github.com/timescale/timescaledb/blob/main/.unreleased/pr_7020 ? It right now says:
Implements: #7020: Add support for the chunk column statistics tracking.
At this point would be better to change the release PRs. |
For better understanding we've decided to rename the public API from `{enable|disable}_column_stats` to `{enable|disable}_chunk_skipping`.
6e60082
to
98874e0
Compare
Automated backport to 2.15.x not done: cherry-pick failed. Git status
|
For better understanding we've decided to rename the public API from
{enable|disable}_column_stats
to{enable|disable}_chunk_skipping
.Disable-check: force-changelog-file
Disable-check: commit-count