Don't propagate FK lookup queries to osm chunks #7167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenklemm
requested review from
fabriziomello,
antekresic,
akuzm,
gayyappan and
pallavisontakke
svenklemm
force-pushed
the
cns_fk
branch
2 times, most recently
from
cc2a48f
to
1ed95b3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7167 +/- ##
==========================================
+ Coverage 80.06% 81.76% +1.69%
==========================================
Files 190 203 +13
Lines 37181 38013 +832
Branches 9450 9856 +406
==========================================
+ Hits 29770 31082 +1312
+ Misses 2997 2966 -31
+ Partials 4414 3965 -449 ☔ View full report in Codecov by Sentry. |
akuzm
reviewed
Jul 31, 2024
akuzm
reviewed
Jul 31, 2024
akuzm
approved these changes
Jul 31, 2024
svenklemm
force-pushed
the
cns_fk
branch
2 times, most recently
from
d18cd97
to
35f7c2e
Compare
fabriziomello
approved these changes
Jul 31, 2024
Skip the OSM chunk when doing hypertable expansion for FK lookup queries. OSM chunks are considered archived data and we dont want to incur the performance hit of querying OSM data on modifications on the FK reference table.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip the OSM chunk when doing hypertable expansion for FK lookup queries. OSM chunks are considered archived data and we dont want to incur the performance hit of querying OSM data on modifications on the FK reference table.
Disable-check: force-changelog-file