Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misalignment on release 2.0.1 #30

Open
ghandrew opened this issue Nov 13, 2020 · 6 comments
Open

Misalignment on release 2.0.1 #30

ghandrew opened this issue Nov 13, 2020 · 6 comments

Comments

@ghandrew
Copy link

I think there is a misalignment between the release version 2.0.1 on npm and the one on github.

On npm is missing the new feature of "ttl" policy. As I can see the latest commit is missing.

Cheers.

@vegidio
Copy link

vegidio commented Dec 3, 2020

Came here to comment the same. The current version on NPM doesn't have the latest changes in master.

@vegidio
Copy link

vegidio commented Dec 3, 2020

I pulled the code from master branch and tried to make it work in my project without much success. Then I looked at the code and there's very evident bug in the implementation because it throws an exception whenever it tries to fetch a cached content.

Taking in consideration that this code was merged into master without the tests passing and with such a clear bug, I'm afraid that this project is abandoned. Which is a pity because it was a very useful package and I admire the amount of work that @timfpark put here. In any case, I forked the repo and corrected this bug.

If anyone is interested to use this corrected version then feel free to install it from my repo: yarn add vegidio-js/react-native-cache.

@timfpark if the project is not abandoned then please let me know and I would be happy to open a PR to have my fix merged and later have an update published on NPM 🙂

@eric-om
Copy link

eric-om commented Dec 16, 2020

@vegidio thank you for this!

@mickmaccallum
Copy link

Any update on this?

@jitenics
Copy link

jitenics commented Jun 2, 2021

I pulled the code from master branch and tried to make it work in my project without much success. Then I looked at the code and there's very evident bug in the implementation because it throws an exception whenever it tries to fetch a cached content.

Taking in consideration that this code was merged into master without the tests passing and with such a clear bug, I'm afraid that this project is abandoned. Which is a pity because it was a very useful package and I admire the amount of work that @timfpark put here. In any case, I forked the repo and corrected this bug.

If anyone is interested to use this corrected version then feel free to install it from my repo: yarn add vegidio-js/react-native-cache.

@timfpark if the project is not abandoned then please let me know and I would be happy to open a PR to have my fix merged and later have an update published on NPM 🙂

@vegidio there is promise warning as there is not gettime function found on line number 106 in cache.ts file, i am new to react native can you help me in that?

@vegidio
Copy link

vegidio commented Jun 3, 2021

@jitenics I will check this over the weekend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants