Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Next job with LIMIT teamSize (Performance Boost) #32

Closed
wants to merge 2 commits into from
Closed

Next job with LIMIT teamSize (Performance Boost) #32

wants to merge 2 commits into from

Conversation

phips28
Copy link
Contributor

@phips28 phips28 commented May 9, 2017

changed behaviour of teamSize > 1:

  • do not start multiple workers, just one!
  • fetch jobs with a LIMIT teamSize to get multiple jobs with one query

Pros:

  • saves connections to db
  • less queries
  • less db work (-CPU)

@phips28
changed behaviour of teamSize > 1:
3dfcd00 
- do not start multiple workers, just one!
- fetch jobs with a `LIMIT teamSize` to get multiple jobs with one query
@phips28
- 1.1.1
ccaa97c
@phips28 phips28 mentioned this pull request May 9, 2017
Closed
@coveralls
Copy link

coveralls commented May 10, 2017 •
edited

Coverage Status

Coverage decreased (-0.2%) to 99.761% when pulling ccaa97c on phips28:next_job_with_limit_teamsize into ccbb848 on timgit:master.

@timgit
Copy link
Owner

timgit commented May 12, 2017

Closing this as it's been manually merged into 2.0. Thx

@timgit timgit closed this May 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@phips28 @coveralls @timgit