Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Finish tracking Julia 0.4 Dict changes #205

Merged
merged 2 commits into from
Oct 9, 2014

Conversation

garborg
Copy link
Contributor

@garborg garborg commented Oct 8, 2014

The second commit shows only Dict changes.

There were a couple spots where I'm not completely sure @Dict doesn't have to be qualified with Images -- will point out in the code.

@garborg
Copy link
Contributor Author

garborg commented Oct 9, 2014

Okay, those are the two spots I was unsure of -- just not familiar enough with how those files are used.

@garborg
Copy link
Contributor Author

garborg commented Oct 9, 2014

Also, the tests fail for me on OSX on 0.3 and master, before and after these commits -- not sure if there's something I should change to get around that:

INFO: Testing Images
WARNING: OSX reader: indexed color images not implemented
ERROR: test failed: Images.data(b) == convert(Array{RGB{Ufixed8},2},Images.data(Images.restrict(abig,(1,2))))
 in error at error.jl:21
 in default_handler at test.jl:19
...
 in _start at /Users/sean/repos/julia03/usr/lib/julia/sys.dylib
while loading /Users/sean/.julia/v0.4/Images/test/io.jl, in expression starting on line 62

@timholy
Copy link
Member

timholy commented Oct 9, 2014

This is awesome---thanks for doing this! Once the qualifiers are added, I'll merge. (The ioformats are loaded after Images is done, so they live outside the module.)

I'm also interested in the test failure; not having a mac, I didn't realize that was an issue. Can you tell what the difference between the images is? One thing to check for is if it's an RGB vs sRGB thing; that would show up as "stretched" color values.

@garborg
Copy link
Contributor Author

garborg commented Oct 9, 2014

Okay, I added the qualifiers, and I also realized the AnyDict didn't need to stay untyped, so I got rid of the @AnyDict macro I had added.

I haven't looked for the difference beween the images yet, but I will.

@garborg
Copy link
Contributor Author

garborg commented Oct 9, 2014

I'll open a separate issue for the tests on OSX... convert is breaking on 0.3 for me as well as 0.4, and I don't have time to rebuild before I head out.

timholy added a commit that referenced this pull request Oct 9, 2014
WIP: Finish tracking Julia 0.4 Dict changes
@timholy timholy merged commit 0d586eb into JuliaImages:master Oct 9, 2014
@timholy
Copy link
Member

timholy commented Oct 9, 2014

Thanks again, this is really great!

@garborg garborg deleted the trackdict branch October 9, 2014 02:04
@garborg
Copy link
Contributor Author

garborg commented Oct 9, 2014

As a casual user of Images, it's nice to be able to help in some small way 😄

@timholy
Copy link
Member

timholy commented Oct 9, 2014

It is greatly appreciated. Helps keep me believing it's all worth it 😄.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants