-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Finish tracking Julia 0.4 Dict changes #205
Conversation
Okay, those are the two spots I was unsure of -- just not familiar enough with how those files are used. |
Also, the tests fail for me on OSX on 0.3 and master, before and after these commits -- not sure if there's something I should change to get around that:
|
This is awesome---thanks for doing this! Once the qualifiers are added, I'll merge. (The I'm also interested in the test failure; not having a mac, I didn't realize that was an issue. Can you tell what the difference between the images is? One thing to check for is if it's an RGB vs sRGB thing; that would show up as "stretched" color values. |
Okay, I added the qualifiers, and I also realized the I haven't looked for the difference beween the images yet, but I will. |
I'll open a separate issue for the tests on OSX... |
WIP: Finish tracking Julia 0.4 Dict changes
Thanks again, this is really great! |
As a casual user of Images, it's nice to be able to help in some small way 😄 |
It is greatly appreciated. Helps keep me believing it's all worth it 😄. |
The second commit shows only Dict changes.
There were a couple spots where I'm not completely sure
@Dict
doesn't have to be qualified withImages
-- will point out in the code.