Add support for Cthulhu #101

timholy · 2020-06-23T18:10:20Z

This is the final tool (so far) for fixing invalidations. ascend makes it much easier to identify a fruitful place to intervene and fix inference problems.

This also adds tools for bumping the versions across-the-board. What do you think of this, @aminya? Overall I think our best strategy is to keep all version numbers in lock-step, and that's the workflow made easy with these tools. When you want to bump the version, you say bump_version(v"1.7.0"). After the PR merges, update your local master branch to the latest, check out a branch of registries/General, and then register_all(). Then submit your registries/General as a PR.

timholy · 2020-06-23T18:12:44Z

Argh, we're being bitten by JuliaLang/Pkg.jl#1874. Naturally. I'd forgotten about that for a moment.

Have to switch to other things, will consider a fix soon.

aminya · 2020-06-23T19:24:35Z

Thanks for this! I think this bump_version should eventually go to Pkg. I will take a more thorough look soon.

KristofferC · 2020-06-23T19:59:00Z

Thanks for this! I think this bump_version should eventually go to Pkg.

Probably better in RegistryTools or something similar. Remember that Pkg has the disadvantage of being a stdlib and is thus slow to make fixes for and should not ideally break it's API etc. Seems much better for something like this somewhere without these constraints.

timholy · 2020-06-23T22:06:52Z

Thanks @KristofferC for suggesting the manifest.

@aminya, I switched the doc-build to nightly, since only nightly has the capabilities for the invalidations. I also fixed a couple of issues with the bot docs that emerged due to the split. Unfortunately we have two broken hyperlinks, from @snoopr to invalidation_trees and back, due to the fact that neither module knows about the other. I don't see a good fix for that. It's only an issue in the reference section.

aminya · 2020-06-23T22:45:04Z

.github/workflows/Documenter.yml

@@ -11,6 +11,9 @@ jobs:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2
+      - uses: julia-actions/setup-julia@latest
+        with:
+          version: nightly


Adding this to both Documenter.yml and ci.yml can solve the downloading issues partially.

Suggested change

version: nightly

version: nightly

- name: Cache artifacts

uses: actions/cache@v1

env:

cache-name: cache-artifacts

with:

path: ~/.julia/artifacts

key: ${{ runner.os }}-test-${{ env.cache-name }}-${{ hashFiles('**/Project.toml') }}

restore-keys: |

${{ runner.os }}-test-${{ env.cache-name }}-

${{ runner.os }}-test-

${{ runner.os }}-

aminya · 2020-06-23T22:48:59Z

Unfortunately we have two broken hyperlinks, from @snoopr to invalidation_trees and back, due to the fact that neither module knows about the other. I don't see a good fix for that. It's only an issue in the reference section.

This is this issue. I suggested a possible solution some time back, but I got no reaction.
JuliaDocs/Documenter.jl#688

We can use full links instead of [](@ref), to solve that temporarily

timholy · 2020-06-23T22:49:26Z

Cthulthu 1.2.0 is not installed automatically. Is it registered?

Yep, just update your packages. https://github.com/JuliaDebug/Cthulhu.jl/releases/tag/v1.2.0

aminya · 2020-06-23T23:04:47Z

OK, I can finally pass the tests locally.

It might be an issue from my end. I fail to update my registry.

(@v1.6) pkg> up
   Updating registry at `C:\Users\yahyaaba\.julia\registries\General`
┌ Warning: Some registries failed to update:
│     — `C:\Users\yahyaaba\.julia\registries\General` — registry dirty
└ @ Pkg.Types D:\buildbot\worker\package_win64\build\usr\share\julia\stdlib\v1.6\Pkg\src\Types.jl:1194
No Changes to `C:\Users\yahyaaba\.julia\environments\v1.6\Project.toml` 
No Changes to `C:\Users\yahyaaba\.julia\environments\v1.6\Manifest.toml`

I had to delete my julia/registries to fix this.

aminya · 2020-06-23T23:42:19Z

SnoopCompileBot/src/SnoopCompileBot.jl

@@ -4,6 +4,7 @@ export BotConfig, snoop_bot, snoop_bench

 using Core: MethodInstance, CodeInfo
 using YAML
+using SnoopCompileCore   # needed for the [`@snoopi`](@ref) doc links


Do we really need to do this? 🤔 Now I use external processes for snooping, and so I don't use SnoopCompileCore directly. So, I prefer to use full links instead of loading the package. It does not seem a good approach to load the packages just for the sake of cross-links.

Suggested change

using SnoopCompileCore # needed for the [`@snoopi`](@ref) doc links

I see your point, given that you do everything in external processes this is not ideal and should probably be deleted. But the manual cross-link is not as robust. Suppose someone makes some local changes and builds the docs locally. Then won't cross-links refer, not to their local copy of the documentation, but to the global one? That's not good.

aminya · 2020-06-24T01:29:13Z

I made a simple fix for cross-linking in Documenter. Let's see if it gets approved.
https://github.com/JuliaDocs/Documenter.jl/pull/1351/files

aminya

@timholy Are we adding this as a patch or a minor?

If this is going to be a minor, could we fix #105 in a patch before merging this?

timholy · 2020-06-24T21:43:26Z

This has now been rebased.

Long-term we definitely don't want the utils/register.jl, but in the short term I think let's live with it. The API is not yet general enough for RegistryTools.jl.

If you need to add your dev script then perhaps utils/ would be a better place.

aminya · 2020-06-24T22:13:28Z

Could we merge ~~#103~~ and #109 to this PR as well?

aminya · 2020-06-24T22:32:12Z

I could not rebase, the conflicts were too much. I made a new PR to this branch:
#110

timholy · 2020-06-25T15:45:44Z

I'm going to hold off on this until we get 1.6.2 out which fixes the bot.

Co-Authored-By: Kristoffer Carlsson <kcarlsson89@gmail.com>

This is a sufficiently common operation it makes sense to export it.

Its ability to diagonse ambiguity is often wrong and will soon be superseded by not reporting cases of ambiguity.

timholy · 2020-06-30T14:19:40Z

Given #111 (comment) I think it means the bot is working again. Shall we merge this before or after fixing the conflicts in #110? Either is fine by me.

aminya · 2020-06-30T22:25:52Z

@timholy I have fixed the conflicts a couple of times so far. But they sneak in again.😉😄

timholy force-pushed the teh/cthulhu branch from 2079ed6 to 8d49a34 Compare June 23, 2020 19:03

timholy mentioned this pull request Jun 23, 2020

Feature request: scan subdirs for updated versions/projects JuliaLang/Pkg.jl#1874

Closed

timholy force-pushed the teh/cthulhu branch from 8d49a34 to 41922f4 Compare June 23, 2020 20:23

This comment has been minimized.

Sign in to view

aminya reviewed Jun 23, 2020

View reviewed changes

This comment has been minimized.

Sign in to view

timholy mentioned this pull request Jun 23, 2020

Startup time regression on master vs 1.5 JuliaLang/julia#36391

Closed

aminya reviewed Jun 23, 2020

View reviewed changes

aminya suggested changes Jun 24, 2020

View reviewed changes

timholy mentioned this pull request Jun 24, 2020

Fixing addtestdep not defined #104

Closed

timholy force-pushed the teh/cthulhu branch from e425e31 to 0f862fd Compare June 24, 2020 21:41

timholy force-pushed the teh/cthulhu branch from 8e537c3 to f4d0c88 Compare June 29, 2020 18:01

timholy and others added 6 commits June 30, 2020 02:59

Support Cthulhu.ascend

e2a29a6

Add utilities for multi-package registration

14d3ded

Version 1.7.0

8d9a335

Add dev script (#109)

417e1b5

Co-Authored-By: Kristoffer Carlsson <kcarlsson89@gmail.com>

Add uinvalidated to get unique MethodInstances

68d23b3

This is a sufficiently common operation it makes sense to export it.

Disable printing of diagnosis

89415f0

Its ability to diagonse ambiguity is often wrong and will soon be superseded by not reporting cases of ambiguity.

timholy force-pushed the teh/cthulhu branch from f4d0c88 to 89415f0 Compare June 30, 2020 08:04

aminya and others added 2 commits June 30, 2020 17:39

Minor doc tweaking (#110)

d3fdbd3

Add a remark about folding

1cffe02

timholy merged commit 8b496f3 into master Jun 30, 2020

timholy deleted the teh/cthulhu branch June 30, 2020 23:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for Cthulhu #101

Add support for Cthulhu #101

timholy commented Jun 23, 2020 •

edited

Loading

timholy commented Jun 23, 2020

aminya commented Jun 23, 2020

KristofferC commented Jun 23, 2020 •

edited

Loading

timholy commented Jun 23, 2020

This comment has been minimized.

aminya Jun 23, 2020 •

edited

Loading

aminya commented Jun 23, 2020

timholy commented Jun 23, 2020

This comment has been minimized.

aminya commented Jun 23, 2020

aminya Jun 23, 2020 •

edited

Loading

timholy Jun 24, 2020

aminya commented Jun 24, 2020

aminya left a comment

timholy commented Jun 24, 2020

aminya commented Jun 24, 2020 •

edited

Loading

aminya commented Jun 24, 2020

timholy commented Jun 25, 2020

timholy commented Jun 30, 2020

aminya commented Jun 30, 2020

-          version: nightly
+          version: nightly
+      - name: Cache artifacts
+        uses: actions/cache@v1
+        env:
+          cache-name: cache-artifacts
+        with:
+          path: ~/.julia/artifacts
+          key: ${{ runner.os }}-test-${{ env.cache-name }}-${{ hashFiles('**/Project.toml') }}
+          restore-keys: |
+            ${{ runner.os }}-test-${{ env.cache-name }}-
+            ${{ runner.os }}-test-
+            ${{ runner.os }}-

Add support for Cthulhu #101

Add support for Cthulhu #101

Conversation

timholy commented Jun 23, 2020 • edited Loading

timholy commented Jun 23, 2020

aminya commented Jun 23, 2020

KristofferC commented Jun 23, 2020 • edited Loading

timholy commented Jun 23, 2020

This comment has been minimized.

aminya Jun 23, 2020 • edited Loading

Choose a reason for hiding this comment

aminya commented Jun 23, 2020

timholy commented Jun 23, 2020

This comment has been minimized.

aminya commented Jun 23, 2020

aminya Jun 23, 2020 • edited Loading

Choose a reason for hiding this comment

timholy Jun 24, 2020

Choose a reason for hiding this comment

aminya commented Jun 24, 2020

aminya left a comment

Choose a reason for hiding this comment

timholy commented Jun 24, 2020

aminya commented Jun 24, 2020 • edited Loading

aminya commented Jun 24, 2020

timholy commented Jun 25, 2020

timholy commented Jun 30, 2020

aminya commented Jun 30, 2020

timholy commented Jun 23, 2020 •

edited

Loading

KristofferC commented Jun 23, 2020 •

edited

Loading

aminya Jun 23, 2020 •

edited

Loading

aminya Jun 23, 2020 •

edited

Loading

aminya commented Jun 24, 2020 •

edited

Loading