Various changes: thread-safety, allow overwriting files, progress for large uploads, isKindOfClass checks, improved SFSafarViewController auth #21
Conversation
…2Token:accessTokenSecret:appKey:appSecret:completion: Make accessToken optional in +apiRequestWithPath:accessToken:parameters: and return NSMutableURLRequest instead of NSURLRequest
… authentication - tokenAuthenticationURLWithClientIdentifier: method Add method to check wheter returned auth url is an error url (also happens when the user presses cancel on the Dropbox website)
…gate’s dictionaries Use serial operation queue when accessing TJDropbox’s tasks hash table Previously, multiple threads could access these at the same time, so it could be mutated while being read which would result in a crash.
…re trying to move the downloaded file into place. Previously, the move operation would fail if the file already existed.
…official Dropbox Obj-C SDK
…server ever returned an unexpected result, accessing the parsed objects would otherwise result in a crash.
…the file already exists.
|
Sorry, I don't know why some commits appear again in this pull request although you already merged them. I'm new to this pull request thing, so I probably did something that I should have done differently. |
|
I like these changes. Mind if I open a PR myself and modify them a bit before merging? |
|
Sure, or just change it after merging so that my commit messages do not get lost? |
|
Just curious what the status of the changes in this PR are? Having overwrite support is of interest to me and I've had a quick look over the others changes too, especially thread-safety which get 👍 from me. |
|
FWIW, I've been using this code in production in my iOS code editor app Textastic and had no problems with it so far. The upgrade from the v1 API was seamless. |
|
Arg, sorry for the delay on this. Changes look good, I've only got minor things I'd change about it. Will merge so others can use it :) Thanks for contributing! |
|
Alrighty, this has been merged in a3057b5... d7af788 I've opened some follow up tasks for this
I think this definitely warrants a new version once this is all done. Will start working on these one by one. |
|
Also added Textastic to the list of apps using it in 161d29c, happy this was useful to you! |
|
Thanks for sharing this library! |
Here is a quick overview of various changes I made:
You can find more details in the commit messages. It's up to you if you want to merge these changes, but they were necessary so I could use TJDropbox in my app Textastic.