[BUG] grpc-transport does not pass along provided deadline option

[jcready]

Considering this callOpts part is commented out in each of the call types I assume this was thought about at one point. It is clear from trying to debug this by passing along the full input options parameter that that solution won't work. It seems like picking individual keys out of the passed options is the only way this will work.

protobuf-ts/packages/grpc-transport/src/grpc-transport.ts

Lines 52 to 59 in bb4a4fc

	const gCall = client.makeUnaryRequest<I, O>(
	`/${method.service.typeName}/${method.name}`,
	(value: I): Buffer => Buffer.from(method.I.toBinary(value, opt.binaryOptions)),
	(value: Buffer): O => method.O.fromBinary(value, opt.binaryOptions),
	input,
	gMeta,
	// callOpts,
	(err, value) => {

protobuf-ts/packages/grpc-transport/src/grpc-transport.ts

Lines 120 to 127 in bb4a4fc

	const gCall = client.makeServerStreamRequest<I, O>(
	`/${method.service.typeName}/${method.name}`,
	(value: I): Buffer => Buffer.from(method.I.toBinary(value, opt.binaryOptions)),
	(value: Buffer): O => method.O.fromBinary(value, opt.binaryOptions),
	input,
	gMeta,
	// callOpts
	);

protobuf-ts/packages/grpc-transport/src/grpc-transport.ts

Lines 184 to 190 in bb4a4fc

	gCall = client.makeClientStreamRequest<I, O>(
	`/${method.service.typeName}/${method.name}`,
	(value: I): Buffer => Buffer.from(method.I.toBinary(value, opt.binaryOptions)),
	(value: Buffer): O => method.O.fromBinary(value, opt.binaryOptions),
	gMeta,
	// callOpts,
	(err, value) => {

[timostamm]

Thanks for the report, @jcready.

The deadline property of GrpcOptions is now picked up, see commit.

Not tested yet. Will have a closer look as soon as i find a longer piece of free time.

[timostamm]

Released in v2.0.0-alpha.12
Yet to be tested.

[timostamm]

Just tested this. Setting the deadline option in the transport CTOR or a method call arg works.

The following error is raised if the deadline is too short:

RpcError: 4 DEADLINE_EXCEEDED: Deadline exceeded
    at ClientDuplexStreamImpl.<anonymous> (/Users/ts/PhpstormProjects/protobuf-ts/packages/grpc-transport/build/commonjs/grpc-transport.js:152:52)